JICMP

jicmp IcmpSocket.h byte swapping macros don't work on OpenIndiana

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: jicmp-1.2.0
  • Fix Version/s: jicmp-1.2.2, jicmp6-1.0.2
  • Component/s: None
  • Labels:
  • Environment:
    OpenIndiana oi_147

Description

OpenIndiana already has byte swapping function like ntohll defined in <sys/byteorder.h>. IcmpSocket.h's set of byte swapping macros redefine ntohll to BSWAP_64 and thus break compilation.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Reed added a comment -

I believe I have this fixed in both the JICMP and JICMP6 codebases. Do you mind trying a clone to confirm?

I changed the macros to only define ntohll and htonll if they're not already found.

Show
Benjamin Reed added a comment - I believe I have this fixed in both the JICMP and JICMP6 codebases. Do you mind trying a clone to confirm? I changed the macros to only define ntohll and htonll if they're not already found.
Hide
Permalink
Benjamin Reed added a comment -

http://opennms.git.sourceforge.net/gitroot/opennms/jicmp is the git repo to clone, btw

Show
Benjamin Reed added a comment - http://opennms.git.sourceforge.net/gitroot/opennms/jicmp is the git repo to clone, btw

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.4#664-r167664) | Report a problem
Powered by a free Atlassian JIRA open source license for OpenNMS. Try JIRA - bug tracking software for your team.