Patch for performance enhancement to sched outages edit page
Description
Environment
Operating System: All
Platform: All
Acceptance / Success Criteria
None
Attachments
1
Lucidchart Diagrams
Activity
Show:

David Hustace September 21, 2005 at 7:22 PM
Laughs, I was looking at so many bugs tonight, I gave the wrong credit to this change. Sorry, Craig.

David Hustace September 21, 2005 at 7:19 PM
Patch submitted to CVS Stable. Thanks, Mike.

Craig Miskell September 21, 2005 at 6:04 PM
Created an attachment (id=232)
Described patch
Fixed
Details
Assignee
OpenNMS Bug Mailing ListOpenNMS Bug Mailing ListReporter
Craig MiskellCraig MiskellComponents
Fix versions
Affects versions
Priority
Minor
Details
Details
Assignee

Reporter

Components
Fix versions
Affects versions
Priority
PagerDuty
PagerDuty Incident
PagerDuty
PagerDuty Incident
PagerDuty

PagerDuty Incident
Created September 21, 2005 at 6:03 PM
Updated January 27, 2017 at 4:31 PM
Resolved February 20, 2006 at 11:19 AM
Attached is a patch for a performance enhancement for the editoutages.jsp
Scheduled outages editing page. It turns out that "getAllInterfaces" executes
a main query (quick), then one query per interface to get the snmp information
out. For large numbers of interfaces, this is slow, and unnecessary if SNMP
information is not required. This patch provides a new version of
getAllInterfaces that takes a boolean indicating if SNMP info is required. the
old no parameter method uses this new method with parameter true, for
compatibility. editoutages then uses the new method with parameter false.
the patch is against 1.2.0, but I dont' think things have changed that much in
this code since then, and in any case, it's so trivial it's not hard to
recreate manually (hell, this comment has more text than the patch )