Create detectors for all protocol plugins

A GpDetector is currently missing.

We need detectors for every ServiceMonitor in the poller.monitors package.

We should add an attribute for enabled to control which detectors are on by default so that we can also show all available detectors in the default foreign source detectors list.

Add an attribute to what? I think we've had a couple of different ideas on how to decide how to associate detectors with nodes in a requisition...

Based on latest code for 1.10, this is the list of Poller Monitors which don't have any detector associated with it:

Standard Monitors (capsd doesn't provide a plugin for this):

• BSFMonitor
• DNSResolutionMonitor
• MemcachedMonitor
• PassiveServiceMonitor
• StrafePingMonitor
• TrivialTimeMonitor

NOTE: What should be the correct procedure for to handle this monitors from provisiond point of view?

SNMP Monitors:

• CiscoIpSlaMonitor
• CiscoPingMibMonitor
• OmsaStorageMonitor
• OpenManageChassisMonitor
• PercMonitor

Other Monitors:

• GpMonitor (as pointed by Ludovic)
• JMXSecureMonitor (child of JMXMonitor)
• JschSshMonitor
• NsclientMonitor
• WebMonitor

Which of the following monitors is related with SmsDetector?

• SMSPingMonitor
• MobileMsgSequenceMonitor

Complex Monitors (capsd doesn't provide a plugin for this):

• MailTransportMonitor
• PageSequenceMonitor

In case that they need a Detector, how to handle complex configuration for detectors ?

We could use something similar with the current solution, the problem is: how can we handle the inner-xml structure from the requisitions Web Interface?

I hope that I'm not missing any other monitor/detector, and I also hope this information helps.

I could help with the implementations.

Added CiscoIpSlaDetector and OpenManageChassisDetector on revision 169bd88e38f40a9042bdbdb801e8e1e652f87392 for 1.10

Added OmsaStorageDetector and PercDetector on revision 0842cb2b1520a3507ed9089f52da2c1e9fd1a53c for 1.10

Those detectors didn't have their corresponding plugin on Capsd, so the implementation was inspired on OmsaStorageMonitor and PercMonitor.

If a specific virtualArrayDisk (for OMSA) or arrayDisk (for PERC) exists, the service is marked as detected.

Added MemcachedDetector on revision 0b9188782f599953fd407e3ba420a9e37824b04d for 1.10

It seems like the GpDetector exists from a long time...

This is from 1.10 branch:

commit f0d28450444f43c1f8da070146dea1f9a9eddf67
Author: Donald Desloge <thedesloge@users.sourceforge.net>
Date:   Fri May 22 18:16:37 2009 +0000

    Added GpDetector

and this is from 1.8 branch:

commit f0d28450444f43c1f8da070146dea1f9a9eddf67
Author: Donald Desloge <thedesloge@users.sourceforge.net>
Date:   Fri May 22 18:16:37 2009 +0000

    Added GpDetector

It looks like it will work similar to GpPlugin for Capsd.

The NSClientDetector has been committed on revision 6d271f2a3529048205ce39b973292f11b5174c6e for 1.10

I also have been refactored the common code for nsclient to be placed on a separate package in order to share the code between opennms-services and opennms-detector-lineoriented.

I added a simple JUnit test with a Mock Server for the NSClientDetector, and I've also tested the solution with a real Windows Server using NSClient 0.3.9 (to test the detector and data collection).

The WebDetector (based on WebPlugin with some minor enhancements) has been committed on revision 9e723c91aa99c70ad1d5d081229209eb4ea326b2 for 1.10

The BSFDetector (based on BSFMonitor) has been committed on revision 69fca4199de79c206e80a2d586f761d1031c0eb8 for 1.10

An example usage is:

<detector class="org.opennms.netmgt.provision.detector.bsf.BSFDetector" name="BSF-Sample">
    <parameter value="org.codehaus.groovy.bsf.GroovyEngine" key="bsfEngine"/>
    <parameter value="groovy,gy" key="fileExtensions"/>
    <parameter value="/opt/opennms/scripts/test.groovy" key="fileName"/>
    <parameter value="groovy" key="langClass"/>
    <parameter value="exec" key="runType"/>
</detector>

The only difference with BSFMonitor is the availability of the nodeId and nodeLabel on the scripts. Those variables are not available now.

This is an usage example for WebDetector:

<detector class="org.opennms.netmgt.provision.detector.web.WebDetector" name="OpenNMSWebApp">
    <parameter value="8980" key="port"/>
    <parameter value="/opennms/index.jsp" key="path"/>
    <parameter value="true" key="authEnabled"/>
    <parameter value="admin" key="authUser"/>
    <parameter value="admin" key="authPassword"/>
    <parameter value="~OpenNMS Web Console" key="responseText"/>
</detector>

The JdbcQueryDetector (based on JdbcQueryPlugin) has been committed on revision d3ae5e8e33c8d36cf539c157a2bdf78b49658e51 for 1.10

An example usage is:

<detector class="org.opennms.netmgt.provision.detector.jdbc.JdbcQueryDetector" name="NODE_QUERY">
    <parameter value="org.postgresql.Driver" key="dbDriver"/>
    <parameter value="opennms" key="user"/>
    <parameter value="opennms" key="password"/>
    <parameter value="jdbc:postgresql://OPENNMS_JDBC_HOSTNAME:5432/syncnms_test" key="url"/>
    <parameter value="select count(nodeid) from node" key="sqlQuery"/>
</detector>

The remaining plugins for Capsd without detectors are:

• JschSshPlugin, which is marked as deprecated by SshPlugin, so I think we could ignore it.
• K5Detector, I don't understand the use case for this (maybe we could ignore it).
• JMXSecureDetector, I don't understand the use case for this. I tried to make a Junit test using OpenDMK without success. Any suggestions?

The remaining monitors for Pollerd without detectors are:

• CiscoPingMonitor
• DNSResolutionMonitor
• MailTransportMonitor
• PageSequenceMonitor
• PassiveSequenceMonitor
• StrafePingMonitor
• TrivialTimeMonitor

Probably I'm wrong, but I think it doesn't make sense to create detectors for those monitors. Thoughts?

I suggest to close this issue, and if someone requires an additional detector then he should report it on a new issue.

It would make sense to have a TrivialTimeDetector. Should be easy to implement too based on the poller monitor code.

Other than that one, I'm in agreement.

The TrivialTimeDetector (based on TrivialTimeMonitor) has been committed on revision 6b4e03a410114d632b8ef9fa1ed3b3322ce8d198 for 1.10

An example usage is:

<detector class="org.opennms.netmgt.provision.detector.simple.TrivialTimeDetector" name="UDP_TIME">
    <parameter value="udp" key="protocol"/>
</detector>
<detector class="org.opennms.netmgt.provision.detector.simple.TrivialTimeDetector" name="TCP_TIME"/>

The only remaining detector is JMXSecureDetector and I didn't receive any feedback on the usage of JMXSecurePlugin/JMXSecureMonitor, so I'll close this issue.

If the JMXSecure is needed in the future, a new issue should be created for it.