OpenNMS

Thresholding - Absolutechange stored as floating-point value

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: 1.8.1
  • Fix Version/s: 1.9.92
  • Component/s: Thresholding
  • Security Level: Default (Default Security Scheme)
  • Labels:
    None
  • Environment:
    Operating System: All
    Platform: PC
  • Bugzilla Id:
    3992

Description

When I create a AbsoluteChange threshold in the tresholding gui and enter for example 5 as a value then the value that goes into the configuration file is "5.0"

When this is configured like this it seems like i get a notification on every value change.
For example this threshold was triggered.
parms: label="Unknown" ds="upsOutputCurrent1" value="65" instance="null" changeThreshold="5.0" previousValue="67"

absoluteChange works though when I change the value manually in the thresholding.xml to be "5" instead of "5.0"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alejandro Galue added a comment -

Can you provide the thresholds configuration files? It will also be great if you can set DEBUG for COLLECTD on log4j.properties and give me the log message related to thresholds.

I'm trying to reproduce the problem, but it seems to work for me (from junit testing point of view).

Show
Alejandro Galue added a comment - Can you provide the thresholds configuration files? It will also be great if you can set DEBUG for COLLECTD on log4j.properties and give me the log message related to thresholds. I'm trying to reproduce the problem, but it seems to work for me (from junit testing point of view).
Hide
Permalink
Alejandro Galue added a comment -

Check the screenshot.

I configured the data collection using HttpCollector to be executed every 30 seconds. I'm able to control the content of the target page and I can set the value that will be used in the thresholds to whatever I want.

I changed the value many times, but only two of them meet the condition to generate the event.

What am I missing?

Show
Alejandro Galue added a comment - Check the screenshot. I configured the data collection using HttpCollector to be executed every 30 seconds. I'm able to control the content of the target page and I can set the value that will be used in the thresholds to whatever I want. I changed the value many times, but only two of them meet the condition to generate the event. What am I missing?
Hide
Permalink
Alejandro Galue added a comment -

Here is the configuration of the threshold used on my experiments:

<group name="http" rrdRepository="/Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/">
    <threshold type="absoluteChange" ds-type="node" value="10.0"
        rearm="5.0" trigger="1" filterOperator="or" ds-name="testCount"/>
</group>

Here is when the event was generated:

2011-09-16 17:53:22,165 INFO  [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Persisting data for resource org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: Visiting Group AttrGroupType[name=test-counts, ifType=all] for null@6
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: AttrGroupType[name=test-counts, ifType=all] for null@6.shouldPersist = true
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] HttpCollector$HttpCollectionAttribute: Visiting attribute HttpAttribute: testCount:gauge32:85
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Persisting HttpAttribute: testCount:gauge32:85
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Storing attribute HttpAttribute: testCount:gauge32:85
2011-09-16 17:53:22,166 INFO  [CollectdScheduler-50 Pool-fiber2] RrdUtils: createRRD: creating RRD file /Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/6/testCount.jrb
2011-09-16 17:53:22,166 INFO  [CollectdScheduler-50 Pool-fiber2] RrdUtils: updateRRD: updating RRD file /Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/6/testCount.jrb with values '1316211802:85'
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] RrdUtils: updateRRD: RRD update command completed.
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: Visiting Group AttrGroupType[name=test-counts, ifType=all] for null@6
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] HttpCollector$HttpCollectionAttribute: Visiting attribute HttpAttribute: testCount:gauge32:85
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: hasThresholds: node@testCount? true
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdingVisitor: visitAttribute: storing value 85 for attribute named testCount
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: Applying thresholds on org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba using 1 attributes.
2011-09-16 17:53:22,166 INFO  [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: Processing threshold testCount : {evaluator=absoluteChange, dsName=testCount, dsType=node, evaluators=[{ds=testCount, value=10.0, rearm=5.0, trigger=1}]}
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectionResourceWrapper: getAttributeValue: id=org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba.testCount, value= 85.0
2011-09-16 17:53:22,166 INFO  [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: All values found, evaluating
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdEntity: evaluate: value= 85.0 against threshold: {evaluator=absoluteChange, dsName=testCount, dsType=node, evaluators=[{ds=testCount, value=10.0, rearm=5.0, trigger=1}]}
2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdEvaluatorAbsoluteChange$ThresholdEvaluatorStateAbsoluteChange: evaluate: absolute positive change threshold triggered

As you can see the value is 85 but is used as 85.0 when the threshold processing is executed. The reason is because every number is converted to Double before performing threshold calculations.

Show
Alejandro Galue added a comment - Here is the configuration of the threshold used on my experiments: <group name= "http" rrdRepository= "/Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/" > <threshold type= "absoluteChange" ds-type= "node" value= "10.0" rearm= "5.0" trigger= "1" filterOperator= "or" ds-name= "testCount" /> </group> Here is when the event was generated: 2011-09-16 17:53:22,165 INFO [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Persisting data for resource org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: Visiting Group AttrGroupType[name=test-counts, ifType=all] for null @6 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: AttrGroupType[name=test-counts, ifType=all] for null @6.shouldPersist = true 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] HttpCollector$HttpCollectionAttribute: Visiting attribute HttpAttribute: testCount:gauge32:85 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Persisting HttpAttribute: testCount:gauge32:85 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] OneToOnePersister: Storing attribute HttpAttribute: testCount:gauge32:85 2011-09-16 17:53:22,166 INFO [CollectdScheduler-50 Pool-fiber2] RrdUtils: createRRD: creating RRD file /Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/6/testCount.jrb 2011-09-16 17:53:22,166 INFO [CollectdScheduler-50 Pool-fiber2] RrdUtils: updateRRD: updating RRD file /Users/agalue/Development/opennms/git/1.10/target/opennms-1.9.92-SNAPSHOT/share/rrd/snmp/6/testCount.jrb with values '1316211802:85' 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] RrdUtils: updateRRD: RRD update command completed. 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] AttributeGroup: Visiting Group AttrGroupType[name=test-counts, ifType=all] for null @6 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] HttpCollector$HttpCollectionAttribute: Visiting attribute HttpAttribute: testCount:gauge32:85 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: hasThresholds: node@testCount? true 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdingVisitor: visitAttribute: storing value 85 for attribute named testCount 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: Applying thresholds on org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba using 1 attributes. 2011-09-16 17:53:22,166 INFO [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: Processing threshold testCount : {evaluator=absoluteChange, dsName=testCount, dsType=node, evaluators=[{ds=testCount, value=10.0, rearm=5.0, trigger=1}]} 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] CollectionResourceWrapper: getAttributeValue: id=org.opennms.netmgt.collectd.HttpCollector$HttpCollectionResource@6846f5ba.testCount, value= 85.0 2011-09-16 17:53:22,166 INFO [CollectdScheduler-50 Pool-fiber2] CollectorThresholdingSet: applyThresholds: All values found, evaluating 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdEntity: evaluate: value= 85.0 against threshold: {evaluator=absoluteChange, dsName=testCount, dsType=node, evaluators=[{ds=testCount, value=10.0, rearm=5.0, trigger=1}]} 2011-09-16 17:53:22,166 DEBUG [CollectdScheduler-50 Pool-fiber2] ThresholdEvaluatorAbsoluteChange$ThresholdEvaluatorStateAbsoluteChange: evaluate: absolute positive change threshold triggered As you can see the value is 85 but is used as 85.0 when the threshold processing is executed. The reason is because every number is converted to Double before performing threshold calculations.
Hide
Permalink
Alejandro Galue added a comment -

As I was not able to reproduce the problem I'll close this issue.

If you are able to reproduce the problem with a recent version of OpenNMS, please reopen this issue and attach logs, screenshots and all information you can provide in order to help me fix the problem.

Last tests:

I've manually changed the value for the threshold configuration from 10.0 to 10. I've sent the proper event to reload the configuration and everything still works as expected. I've restarted OpenNMS and everything is still working as expected.

I tested the same configuration using latest snapshot for 1.8.15 and it also works as expected.

Show
Alejandro Galue added a comment - As I was not able to reproduce the problem I'll close this issue. If you are able to reproduce the problem with a recent version of OpenNMS, please reopen this issue and attach logs, screenshots and all information you can provide in order to help me fix the problem. Last tests: I've manually changed the value for the threshold configuration from 10.0 to 10. I've sent the proper event to reload the configuration and everything still works as expected. I've restarted OpenNMS and everything is still working as expected. I tested the same configuration using latest snapshot for 1.8.15 and it also works as expected.

People

  • Assignee:
    Alejandro Galue
    Reporter:
    Jon Thor Gudmundsson
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: