Details
-
Type:
Bug
-
Status:
Resolved
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 1.9.6
-
Fix Version/s: 1.9.7
-
Component/s: Reports/Statsd
-
Security Level: Default (Default Security Scheme)
-
Labels:None
Description
You broke the tests before leaving for Mexico.... (hehe)
testJRobinDirectoryUtilRrdExtension and testJRobinDirectoryUtilCustomExtension fail after your latest changes. I tried to figure out how to fix them, but it's hard to tell what the tests are trying to do. Should they return .rrd filenames for files that don't exist? Your only test data is .jrb files, so all of the .rrd-based ones should fail, I would think.
Anyways, I'm confused as to the purpose of the util, if it's only supposed to enumerate files that actually exist, then it needs to be fixed in one way, or if it's supposed to enumerate things that exist, but force the extension you ask for, that's another.
I've @Ignore'd them for now, you can fix them when you get back. Welcome back from Mexico! =)
testJRobinDirectoryUtilRrdExtension and testJRobinDirectoryUtilCustomExtension fail after your latest changes. I tried to figure out how to fix them, but it's hard to tell what the tests are trying to do. Should they return .rrd filenames for files that don't exist? Your only test data is .jrb files, so all of the .rrd-based ones should fail, I would think.
Anyways, I'm confused as to the purpose of the util, if it's only supposed to enumerate files that actually exist, then it needs to be fixed in one way, or if it's supposed to enumerate things that exist, but force the extension you ask for, that's another.
I've @Ignore'd them for now, you can fix them when you get back. Welcome back from Mexico! =)
Fixed the test. Turned out the test was looking in the wrong directory for the rrd files.