OpenNMS

Page Sequence Monitor (PSM) doesn't appear to do retries

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.8.10
  • Fix Version/s: 1.8.12, 1.9.8
  • Component/s: Poller
  • Security Level: Default (Default Security Scheme)
  • Labels:

Description

A customer reported that retries don't seem to be working and verified myself in one of the unit tests by setting a "retry" parameter on any of the tests. Looks the retries were attempted to be implemented with the DefaultHttpMethodRetryHandler and perhaps that doesn't work as expected.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Donald Desloge added a comment -

The PageSequenceMonitor was checking for the wrong parameter for retries. Renamed retry to retries, this should be fixed now.

1.8 commit be2f0af68c71d4c0de731ebc11237242fa9778c2
1.9 commit 5cccebe67510bf8e3d5634f026478c0448d4a951

Show
Donald Desloge added a comment - The PageSequenceMonitor was checking for the wrong parameter for retries. Renamed retry to retries, this should be fixed now. 1.8 commit be2f0af68c71d4c0de731ebc11237242fa9778c2 1.9 commit 5cccebe67510bf8e3d5634f026478c0448d4a951
Hide
Permalink
Donald Desloge added a comment -

The retry only occurs when an IOException happens, this is the default behavior of the HttpClient. If it can't make a successful http method call it will retry.

Show
Donald Desloge added a comment - The retry only occurs when an IOException happens, this is the default behavior of the HttpClient. If it can't make a successful http method call it will retry.
Hide
Permalink
Donald Desloge added a comment -

Reverted back to retry. UnitTests all had retries but the PollerConfig uses retry instead.

Show
Donald Desloge added a comment - Reverted back to retry. UnitTests all had retries but the PollerConfig uses retry instead.
Hide
Permalink
Benjamin Reed added a comment -

This is trickier than it looks, pushing until 1.8.11 and 1.9.8 for now.

Show
Benjamin Reed added a comment - This is trickier than it looks, pushing until 1.8.11 and 1.9.8 for now.
Hide
Permalink
Donald Desloge added a comment -

You can now retry entire sequences with the following parameter.

<parameter key="sequence-retry" value="1" />

1.8 commit dee7c6d5a3561ee62d870a4b9a7ece9b9bcf2833
1.9 commit e6eeffd56addf59d7cffd8188de5b045466b0dee

Show
Donald Desloge added a comment - You can now retry entire sequences with the following parameter. <parameter key= "sequence-retry" value= "1" /> 1.8 commit dee7c6d5a3561ee62d870a4b9a7ece9b9bcf2833 1.9 commit e6eeffd56addf59d7cffd8188de5b045466b0dee

People

  • Assignee:
    Matt Brozowski
    Reporter:
    David Hustace
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: