OpenNMS

Surveillance/Dashboard information incoherent

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 1.8.16, 1.10.0
  • Fix Version/s: 1.10.10
  • Component/s: Web UI - Dashboard, Web UI - Surveillance
  • Security Level: Default (Default Security Scheme)
  • Labels:
    None
  • Environment:
    OpenNMS 1.8.16
    CentOS 5.4 / RHEL 5.4
    Java 1.6.23

Description

In both Surveillance and Dashboard, I've got several cells with the information suggested by the attachment file: yellow or red color with "0 of X" text.

Since color means the number of services down (view source-code "SurveillanceStatus" and "NodeDaoHibernate$SimpleSurveillanceStatus"), I don't understand why "0 of X". I should see a number greater than 0 in the text, right?

Issue Links

blocks

Enhancement - An improvement or enhancement to an existing feature or task. NMS-5315 The dashboard page Surveillance View device counts are misleading

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
depends on

Bug - A problem which impairs or prevents the functions of the product. NMS-2330 Surveillance view shows nodes in red when no services are down

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vitor Rui Moreira added a comment -

Patch for class NodeDaoHibernate

Show
Vitor Rui Moreira added a comment - Patch for class NodeDaoHibernate
Hide
Permalink
Vitor Rui Moreira added a comment -

I've analyzed the source code from version 1.8.16 and 1.10.0 and found the following:
"NodeDaoHibernate$SimpleSurveillanceStatus.getDownEntityCount()" returns "m_nodeCount - m_upNodeCount". So, m_nodeCount => total number of nodes and m_upNodeCount => number of nodes without any outage, where "getDownEntityCount" returns the number of nodes with problems.

In "NodeDaoHibernate", in SQL statement:
– original source code –
count(distinct case when outages.outageid is null and monSvc.status = 'A' then node.nodeid else null end) as upNodeCount,
– original source code –

Shouldn't be?
– proposed source code –
count(distinct case when outages.outageid is not null and monSvc.status = 'A' then node.nodeid else null end) as downEntityCount,
– proposed source code –

In method "getDownEntityCount", instead of returning "m_nodeCount-m_upNodeCount", we should return m_downEntityCount directly.

Applying the patch, both Surveillance and Dashboard looks very nice but, when I link in the new "1 of 11", there are any node in the list. I'm working in that now.

Show
Vitor Rui Moreira added a comment - I've analyzed the source code from version 1.8.16 and 1.10.0 and found the following: "NodeDaoHibernate$SimpleSurveillanceStatus.getDownEntityCount()" returns "m_nodeCount - m_upNodeCount". So, m_nodeCount => total number of nodes and m_upNodeCount => number of nodes without any outage, where "getDownEntityCount" returns the number of nodes with problems. In "NodeDaoHibernate", in SQL statement: – original source code – count(distinct case when outages.outageid is null and monSvc.status = 'A' then node.nodeid else null end) as upNodeCount, – original source code – Shouldn't be? – proposed source code – count(distinct case when outages.outageid is not null and monSvc.status = 'A' then node.nodeid else null end) as downEntityCount, – proposed source code – In method "getDownEntityCount", instead of returning "m_nodeCount-m_upNodeCount", we should return m_downEntityCount directly. Applying the patch, both Surveillance and Dashboard looks very nice but, when I link in the new "1 of 11", there are any node in the list. I'm working in that now.
Hide
Permalink
Vitor Rui Moreira added a comment -

Ok, check the code and found the "AggregatorStatus".
After all, I think the meaning of dashboard is:

  • colors:
    • green: 0 services down
    • yellow: 1 service down
    • red: >1 service down
  • numbers:
    • left number: number of nodes that are actually down
    • right number: total number of nodes
Show
Vitor Rui Moreira added a comment - Ok, check the code and found the "AggregatorStatus". After all, I think the meaning of dashboard is: colors: green: 0 services down yellow: 1 service down red: >1 service down numbers: left number: number of nodes that are actually down right number: total number of nodes
Hide
Permalink
Seth Leger added a comment -

This Hibernate query does have some issues... basically the "0 of 11" means that zero nodes are COMPLETELY unreachable. If they have ANY services that are up, they are not considered down.

We need to enhance the UI so that the meaning is clearer. This issue also causes the confusion in bug NMS-2330.

Show
Seth Leger added a comment - This Hibernate query does have some issues... basically the "0 of 11" means that zero nodes are COMPLETELY unreachable. If they have ANY services that are up, they are not considered down. We need to enhance the UI so that the meaning is clearer. This issue also causes the confusion in bug NMS-2330 .

People

  • Assignee:
    Donald Desloge
    Reporter:
    Vitor Rui Moreira
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: