Details
-
Bug
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
Meridian-2019.1.17, Meridian-2020.1.7, 27.1.1
-
Security Level: Default (Default Security Scheme)
-
None
-
Backlog
Description
When I implemented the evaluation layer, the logic to identify nodes versus interfaces was deterministic:
Unfortunately, that is not the case anymore, as now after all the refactoring made over the years (since the evaluation layer exists), and now "getResource().getParent().getName()" returns something different.
With the current state of the code, I think the checkNode method should receive the CollectionResource entity. There, check the resource type, decide if the resource belongs to Pollerd (interface) or Collectd (node), and increase the appropriate counter.
Currently, both nodes and interfaces are counted as interfaces, and here is how they appear in memory:
2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: 127.0.0.1 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: 192.168.0.40 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: 192.168.205.1 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: 192.168.75.1 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: 192.168.75.47 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: agalue-mbp 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: fd13:ea9b:d4e4:4fc9:c87a:6cff:fe63:ca2c 2021-05-07 13:35:50,656 INFO [pool-2-thread-1] EvaluationMetrics: interface: opennms
The nodes should be agalue-mbp and opennms. The rest are, as you can see, interfaces. Note that "fs/snmp" is not part of the node path identifier anymore. That leads to show the counters as:
2021-05-07 13:46:50,653 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.groups, value=82 2021-05-07 13:46:50,653 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.interfaces, value=8 2021-05-07 13:46:50,654 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.nodes, value=0 2021-05-07 13:46:50,654 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.numeric-attributes, value=287 2021-05-07 13:46:50,654 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.resources, value=44 2021-05-07 13:46:50,654 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=GAUGE, name=evaluate.string-attributes, value=66 2021-05-07 13:46:50,656 INFO [metrics-logger-reporter-1-thread-1] EvaluationMetrics: type=METER, name=evaluate.samples, count=10854, mean_rate=8.614191587123628, m1=8.993287964895432, m5=8.694628203336677, m15=6.564777659036456, rate_unit=events/second
Note that "node" has zero, whereas "interfaces" contains the total number of interfaces plus nodes.
Attachments
Issue Links
- mentioned in
-
Page Loading...
