[NMS-13806] Improve handling of invalid IP addresses during provisioning cycle - The OpenNMS Issue Tracker

XML

Word

Printable

Story Points:
5
Sprint:
Horizon 22 - Feb 2 - Feb 16, Horizon 22 - Feb 16 - Mar 2, Horizon 22 - Mar 2 - 16
HB Backlog Status:
Backlog

While invalid IP addresses should not make their way into a requisition, in the case that they do, the provisiond cycle will stop processing subsequent nodes in the requisition. When encountering an invalid IP, that node (or just that IP) should be skipped to allow other nodes in the requisition to complete the import cycle.
When importing a requisition from a non-file source (such as an HTTP location), there should be an additional check for IP validity and omit/log invalid IP addresses to prevent them from being written to the requisition file.
Invalid IP addresses are only written to provisiond.log when in DEBUG mode. Including invalid IP addresses in WARN mode will help users identify the issue in a timely manner. And after ~~PRIS-157~~ and ~~NMS-13805~~, should have a lower chance of making their way into a requisition.

related to

NMS-13805 Validate IP Addresses when adding/updating nodes via REST API

PRIS-157 IP Addresses are not validated before generating requisition