Invalid node Foreign ID not checked during provisioning resulting in various RRD graphing problems

Invalid foreign ID such as with character : injected via non-GUI methods such as editing the XML file directly or REST or PRIS import can cause various RRD graphing problems.

Steps to reproduce

Use REST API to add nodes into a requisition such as

curl -u username:password -X POST -H "Content-Type: application/xml" -d @mynode.xml http://localhost:8980/opennms/rest/requisitions/Support/nodes

mynode.xml

<node foreign-id="mynode:2" node-label="mynode2">
 <interface ip-addr="127.0.1.5" status="1" snmp-primary="P"/>
</node>

Note the foreign-id is in the invalid form and the Foreign ID field validation check won't apply here.

Navigating to Resource Graph for this node will return "Query failed." for all the graphs. The Data tab will show blank.

Additionally, clicking on the node from that page which will direct the url to
_http://localhost:8980/opennms/element/node.jsp?node=Support:mynode:2_

results in "Node Not Found" error page.

Verified that data collection is working and data is persisted to RRD files.