Bubble-up submap status (not severity)

Description

When viewing the 'Status' view of a map, it would be great if the icons for child submaps would display the worst condition of any element of the submap.

For example, if you have a map of the USA, a submap for Illinois, and a router in Chicago, IL that is down (e.g. the 'Status' view shows it as red because of the existence of an uei.opennms.org/nodes/nodeDown alarm for that node id), then the icon for Illinois should show as red with a 'nodeDown' status as well. Currently, it defaults to grey because the submap icon/object isn't really a node or device, and can't have alarms.

Since the status IDs are numeric and already ordered from worst to best in map.properties, then the summarization function could simply be "the smallest number in a recursive search through all the map's children."

If this was implemented, then it would behave similarly to how the 'Severity' map view already does.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Antonio Russo October 22, 2011 at 1:06 PM

fixed in 1.8 and 1.10

To ssh://rssntn67@opennms.git.sourceforge.net/gitroot/opennms/opennms
699f2da..c0a462f 1.10 -> 1.10
3652032..2577d52 1.8 -> 1.8

Antonio Russo October 22, 2011 at 6:58 AM

Well, now I see!

But we have three criteria for defining the severity of a "submap"
avg => "the severity shown is the average among the severities on all nodes"
worst => "select the worst severity on nodes"
best => "select the best severity found on nodes"

Now what should be the criteria for the status
worst and best have meaning here too but avg has no particular meaning.
Because we cannot change the configuration files on stable production here is what I'm going to do...
Selecting best you got either best severity and best status
Selecting worst you got either worst severity and worst status
Selecting avg you got avg severity and worst status

Any comments before committing the required changes?

Antonio Russo October 22, 2011 at 6:38 AM

I rewrote the Manager code several times.....it is very uncomfortable!

Should be rewritten!

Antonio Russo October 22, 2011 at 4:34 AM

So, you mean that there is no "worst strategy for status!

I reproduce your issue!

Well, just leave me seconds to further verify the patch, I'll commit ASAP!

Dave Caplinger October 21, 2011 at 4:56 PM

OK, I verified that the AlarmInfo() stuff was in fact the code path that is being used.

So here's a patch that fixes the problem:

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created October 7, 2011 at 6:35 PM
Updated January 27, 2017 at 4:20 PM
Resolved October 22, 2011 at 1:06 PM