Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-4928

RadiusAuthenticationProvider.java Tests against wrong variable.

    XMLWordPrintable

    Details

      Description

      RadiusAuthenticationProvider.java in
      opennms/features/springframework-security/src/main/java/org/opennms/web/springframework/security
      Has the following code which tests the wrong variable:

      RadiusAuthenticationProvider.java

      public RadiusAuthenticationProvider(String server, String secret)

      { Assert.hasLength(server, "A server must be specified"); this.server = server; Assert.hasLength(server, "A shared secret must be specified"); this.secret = secret; }

      Assert.hasLength(server, "A shared secret must be specified");
      should be
      Assert.hasLength(secret, "A shared secret must be specified");

        Attachments

          Activity

            People

            Assignee:
            agalue Alejandro Galue
            Reporter:
            jfpopennms Jean-Francois Pirus (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 5 minutes
                5m
                Remaining:
                Remaining Estimate - 5 minutes
                5m
                Logged:
                Time Spent - Not Specified
                Not Specified