Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-5646

JRobinRrdStrategy in master has bogus import of antlr.StringUtils

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.11.3
    • Fix Version/s: 1.11.90
    • Component/s: Logging
    • Security Level: Default (Default Security Scheme)
    • Labels:
      None

      Description

      In commit 04e46234 (and going back throught the whole nrtg revert revert reverts), JRobinRrdStrategy had a imported class changed:

      diff --git a/opennms-rrd/opennms-rrd-jrobin/src/main/java/org/opennms/netmgt/rrd/jrobin/JRobinRrdStrategy.java b/opennms
      index 18e3b77..4af404d 100644
      --- a/opennms-rrd/opennms-rrd-jrobin/src/main/java/org/opennms/netmgt/rrd/jrobin/JRobinRrdStrategy.java
      +++ b/opennms-rrd/opennms-rrd-jrobin/src/main/java/org/opennms/netmgt/rrd/jrobin/JRobinRrdStrategy.java
      @@ -50,13 +50,14 @@ import org.jrobin.data.DataProcessor;
       import org.jrobin.data.Plottable;
       import org.jrobin.graph.RrdGraph;
       import org.jrobin.graph.RrdGraphDef;
      -import org.opennms.core.utils.StringUtils;
       import org.opennms.core.utils.ThreadCategory;
       import org.opennms.netmgt.rrd.RrdDataSource;
       import org.opennms.netmgt.rrd.RrdGraphDetails;
       import org.opennms.netmgt.rrd.RrdStrategy;
       import org.opennms.netmgt.rrd.RrdUtils;
      
      +import antlr.StringUtils;
      +
      -----
      

      This part of the commit should be reverted back (importing org.opennms.core.utils.StringUtils, rather than antlr.StringUtils) because the only use of StringUtils is for logging purposes within the static method tokenizeWithQuotingAndEscapes.

        Attachments

          Activity

            People

            • Assignee:
              seth Seth Leger
              Reporter:
              ronald.roskens@biworldwide.com Ron Roskens
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: