Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-6545

ResourceDao.findTopLevelResources() is returning duplicated data because of storeByForeignSource

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.12.6, 1.13.1
    • Fix Version/s: 1.12.7, 1.13.2
    • Component/s: Architecture
    • Security Level: Default (Default Security Scheme)
    • Labels:
    • Sprint:
      NMS Sprint 2

      Description

      The current implementation of the findTopLevelResources method of the ResourceDAO class is not correct no matter if storeByForeignSource is enabled or not.

      The reason is that it is not possible to make findNodeResources() and findNodeSourceResources() independent of each other without duplicating the effort on their implementations.

      For this reason, the resource calculation must be performed once on the same method. That way, no matter if storeByForeignSource is enabled or not, the Top Level Resources are going to be listed only once.

      This method is mainly used by Statsd and KSC Reports.

      As a consequence, I found several inconsistencies on the KSC's JSPs.

        Attachments

          Activity

            People

            • Assignee:
              agalue Alejandro Galue
              Reporter:
              agalue Alejandro Galue
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: