Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-7388

IpInterfaceScan shouldDetect() method should check for empty string in addition to null string

    XMLWordPrintable

    Details

      Description

      I'm writing a detector for protocol XMP.

      My XmpDetector was returning empty string for ipMatch method and IpInterfaceScan shouldDetect() method was only checking for null string. Null string and empty string are semantically same but code was not catching.

      I added check for empty string to shouldDetect() and am testing now. I will submit enhancement with my XmpDetector via my pull request.

      Thanks,

      Bobby

        Attachments

          Activity

            People

            • Assignee:
              ranger Benjamin Reed
              Reporter:
              rdk Bobby Krupczak
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 1 hour
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified