Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-7551

DiskUsageMonitor never fails with a non existing disk

    Details

      Description

      DiskUsageMonitor.poll() never fails a service poll with the "could not find

      {diskName}

      in table" status any more.

      If we are able to walk hrStorageTableDescr, and get no results, it will return a PollStatus.unavailable();

      Then during the iteration through they entryset of results, we flip foundDisk to true, after which since foundDisk is true, we return the status object which was set to PollStatus.available().

      So if you had a poll for disk /data, and it wasn't found in the hrStorageDescr columns, it would be marked as available even though it doesn't exist!

      DiskUsageMonitor needs a unit test built for it to test all these logic paths.

        Attachments

          Activity

            People

            • Assignee:
              j-white Jesse White
              Reporter:
              ronald.roskens@biworldwide.com Ron Roskens
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: