Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-7978

Add threshold comments and whitespace changes to match how the OpenNMS web GUI generates XML files

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 17.0.0
    • Fix Version/s: 17.1.0
    • Component/s: Thresholding
    • Security Level: Default (Default Security Scheme)
    • Labels:
      None

      Description

      This is a proposed patch that does the following:

      1. thresholds.xml

      • Add descriptions to all thresholds to add documentation on what each threshold is for
      • Change whitespace and ordering to match how the OpenNMS web UI generates the file; I used the web GUI to open each threshold in the editor and then saved it WITH NO CHANGES (other than the description) to get OpenNMS just to rewrite the file formatting. The issue here is it is much easier to diff a new version of the file with the one in production if the whitespace and XML formatting match how the GUI edits the file.

      2. eventconf.xml

      • Added a comment about file ordering for documentation purposes
      • Remove extraneous blank lines

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              timmillerdyck Tim Miller Dyck
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 15 minutes
                15m
                Remaining:
                Remaining Estimate - 15 minutes
                15m
                Logged:
                Time Spent - Not Specified
                Not Specified