Uploaded image for project: 'OpenNMS'
  1. OpenNMS
  2. NMS-8899

The pristine etc contains a number of TODOs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 19.0.0
    • Fix Version/s: 19.0.0
    • Component/s: Data Collection - JMX
    • Security Level: Default (Default Security Scheme)
    • Labels:
      None
    • Sprint:
      Horizon - Nov 23rd, Horizon - Nov 30th, Horizon - Dec 7th, Horizon - Dec 14th, Horizon - Jan 11th, Horizon - Jan 25th

      Description

      A pristine copy of our 'etc' folder now contains a number of TODOs:

      $ find . -type f | xargs grep -i 'TODO: '
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine these next two graphs?
      ./snmp-graph.properties.d/kafka-graphs.properties:# TODO: Combine Produce, FetchConsumer, and FetchFollower metrics on single graphs?
      ./collectd-configuration.xml:        <!-- TODO: Rename to 'JMX-OpenNMS' -->
      ./collectd-configuration.xml:    <!-- TODO: Rename to 'JMX-OpenNMS' -->
      ./jmx-datacollection-config.d/minion.xml:                <!-- TODO: Make aliases unique -->
      ./jmx-datacollection-config.d/minion.xml:                <!-- TODO: Make aliases unique -->
      ./jmx-datacollection-config.d/minion.xml:            <!-- TODO: Collect route stats for RPC.Server.Discover (when available) -->
      ./jmx-datacollection-config.d/minion.xml:            <!-- TODO: Collect route stats for RPC.Server.DNS (when available) -->
      ./jmx-datacollection-config.d/minion.xml:            <!-- TODO: Collect route stats for RPC.Server.Poll (when available) -->
      ./jmx-datacollection-config.d/kafka.xml:            <!-- TODO: These metrics are specific to the topic names and should be moved into a separate configuration -->
      

      I'm of the opinion that we should be using alternate means of tracking future updates/enhancements to our configuration files.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                seth Seth Leger
                Reporter:
                j-white Jesse White
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: