From 15ce2fee8ec8b1b463917e4fd4de23779696be03 Mon Sep 17 00:00:00 2001 From: Ronald Roskens Date: Sun, 12 Aug 2012 21:13:36 -0500 Subject: [PATCH] NMS-3872: Add a unique id attribute for outages, and use that instead of the outage name for identification. --- .../src/test/resources/poller-configuration.xml | 2 +- .../etc/examples/collectd-configuration.xml | 4 +- .../main/filtered/etc/examples/poll-outages.xml | 6 +- .../filtered/etc/examples/poller-configuration.xml | 4 +- .../etc/examples/threshd-configuration.xml | 2 +- .../src/main/castor/collectd-configuration.xsd | 15 +- .../src/main/castor/notifd-configuration.xsd | 10 +- .../src/main/castor/poller-configuration.xsd | 12 +- .../src/main/castor/threshd-configuration.xsd | 12 +- .../netmgt/config/poller/BasicSchedule.java | 29 +++- .../descriptors/BasicScheduleDescriptor.java | 44 +++++ .../src/main/resources/xsds/poll-outages.xsd | 6 + .../opennms/netmgt/config/poller/OutageTest.java | 3 +- .../opennms/netmgt/config/poller/OutagesTest.java | 3 +- .../opennms/netmgt/config/NotifdConfigManager.java | 6 +- .../opennms/netmgt/config/PollOutagesConfig.java | 25 ++-- .../netmgt/config/PollOutagesConfigManager.java | 78 ++++++--- .../config/PollOutagesConfigManagerTest.java | 30 ++-- .../opennms/netmgt/config/collectd-testdata.xml | 4 +- .../config/poller-configuration.testdata.xml | 4 +- .../opennms-home/etc/collectd-configuration.xml | 2 +- .../test/opennms-home/etc/poller-configuration.xml | 2 +- .../opennms-home/etc/collectd-configuration.xml | 2 +- .../test/opennms-home/etc/poller-configuration.xml | 2 +- .../resources/collectdconfiguration-testdata.xml | 2 +- .../opennms-home/etc/collectd-configuration.xml | 2 +- .../test/opennms-home/etc/poller-configuration.xml | 2 +- .../netmgt/collectd/CollectionSpecification.java | 10 +- .../netmgt/notifd/BroadcastEventProcessor.java | 20 +- .../poller/pollables/PollableServiceConfig.java | 12 +- .../netmgt/threshd/ThresholdableService.java | 8 +- .../opennms/netmgt/threshd/ThresholdingSet.java | 24 ++-- .../org/opennms/netmgt/mock/MockNetworkTest.java | 33 ++-- .../org/opennms/netmgt/mock/MockPollerConfig.java | 40 +++-- .../test/resources/etc/threshd-configuration.xml | 4 +- .../opennms/netmgt/capsd/poller-configuration.xml | 2 +- .../opennms/netmgt/config/collectd-testdata.xml | 4 +- .../netmgt/poller/remote/poller-configuration.xml | 4 +- .../netmgt/threshd/threshd-configuration.xml | 2 +- .../resources/threshd-configuration-bug3390.xml | 2 +- .../resources/threshd-configuration-bug3554.xml | 18 +- .../resources/threshd-configuration-bug3575.xml | 2 +- .../resources/threshd-configuration-bug3748.xml | 2 +- .../resources/threshd-configuration-outages.xml | 2 +- .../src/test/resources/threshd-configuration.xml | 2 +- .../src/main/groovy/fastProvisioner.groovy | 4 +- .../web/rest/ScheduledOutagesRestService.java | 188 ++++++++++---------- .../main/webapp/admin/sched-outages/editoutage.jsp | 95 ++++++---- .../src/main/webapp/admin/sched-outages/index.jsp | 81 +++++---- .../opennms-home/etc/collectd-configuration.xml | 4 +- .../test/opennms-home/etc/poller-configuration.xml | 2 +- 51 files changed, 525 insertions(+), 353 deletions(-) diff --git a/features/remote-poller-gwt/src/test/resources/poller-configuration.xml b/features/remote-poller-gwt/src/test/resources/poller-configuration.xml index 35d0645..a97bb00 100644 --- a/features/remote-poller-gwt/src/test/resources/poller-configuration.xml +++ b/features/remote-poller-gwt/src/test/resources/poller-configuration.xml @@ -19,7 +19,7 @@ - zzz from poll-outages.xml zzz + 1 diff --git a/opennms-base-assembly/src/main/filtered/etc/examples/collectd-configuration.xml b/opennms-base-assembly/src/main/filtered/etc/examples/collectd-configuration.xml index 824021c..ad6f77c 100644 --- a/opennms-base-assembly/src/main/filtered/etc/examples/collectd-configuration.xml +++ b/opennms-base-assembly/src/main/filtered/etc/examples/collectd-configuration.xml @@ -86,7 +86,7 @@ - zzz from poll-outages.xml zzz + 1 diff --git a/opennms-base-assembly/src/main/filtered/etc/examples/poll-outages.xml b/opennms-base-assembly/src/main/filtered/etc/examples/poll-outages.xml index 8702b37..2d2d729 100644 --- a/opennms-base-assembly/src/main/filtered/etc/examples/poll-outages.xml +++ b/opennms-base-assembly/src/main/filtered/etc/examples/poll-outages.xml @@ -1,6 +1,6 @@ - + - + - + diff --git a/opennms-base-assembly/src/main/filtered/etc/examples/poller-configuration.xml b/opennms-base-assembly/src/main/filtered/etc/examples/poller-configuration.xml index 930de51..270e7fa 100644 --- a/opennms-base-assembly/src/main/filtered/etc/examples/poller-configuration.xml +++ b/opennms-base-assembly/src/main/filtered/etc/examples/poller-configuration.xml @@ -382,7 +382,7 @@ --> - zzz from poll-outages.xml zzz + 1 @@ -454,7 +454,7 @@ - zzz from poll-outages.xml zzz + 1 diff --git a/opennms-base-assembly/src/main/filtered/etc/examples/threshd-configuration.xml b/opennms-base-assembly/src/main/filtered/etc/examples/threshd-configuration.xml index 05f3169..5150819 100644 --- a/opennms-base-assembly/src/main/filtered/etc/examples/threshd-configuration.xml +++ b/opennms-base-assembly/src/main/filtered/etc/examples/threshd-configuration.xml @@ -45,7 +45,7 @@ - zzz from poll-outages.xml zzz + 1 diff --git a/opennms-config-model/src/main/castor/collectd-configuration.xsd b/opennms-config-model/src/main/castor/collectd-configuration.xsd index e84cdaa..321fdd9 100644 --- a/opennms-config-model/src/main/castor/collectd-configuration.xsd +++ b/opennms-config-model/src/main/castor/collectd-configuration.xsd @@ -177,13 +177,7 @@ - - - Scheduled outages - data collection is not - performed during scheduled outages - - + @@ -321,4 +315,11 @@ + + + + Scheduled outage id + + + diff --git a/opennms-config-model/src/main/castor/notifd-configuration.xsd b/opennms-config-model/src/main/castor/notifd-configuration.xsd index 4e6acdf..9e50ad6 100644 --- a/opennms-config-model/src/main/castor/notifd-configuration.xsd +++ b/opennms-config-model/src/main/castor/notifd-configuration.xsd @@ -25,8 +25,7 @@ - + @@ -103,4 +102,11 @@ + + + + Scheduled outage id + + + diff --git a/opennms-config-model/src/main/castor/poller-configuration.xsd b/opennms-config-model/src/main/castor/poller-configuration.xsd index a470b45..c4abae1 100644 --- a/opennms-config-model/src/main/castor/poller-configuration.xsd +++ b/opennms-config-model/src/main/castor/poller-configuration.xsd @@ -253,10 +253,9 @@ - + - Scheduled outages. If a service is found down + Scheduled outage id. If a service is found down during this period, it is not reported as down. @@ -490,4 +489,11 @@ + + + + Scheduled outage id + + + diff --git a/opennms-config-model/src/main/castor/threshd-configuration.xsd b/opennms-config-model/src/main/castor/threshd-configuration.xsd index 368be6c..0076ef3 100644 --- a/opennms-config-model/src/main/castor/threshd-configuration.xsd +++ b/opennms-config-model/src/main/castor/threshd-configuration.xsd @@ -127,10 +127,9 @@ - + - Scheduled outages. Thresholding is not performed + Scheduled outage id. Thresholding is not performed during scheduled outages. @@ -272,4 +271,11 @@ + + + + Scheduled outage id + + + diff --git a/opennms-config-model/src/main/java/org/opennms/netmgt/config/poller/BasicSchedule.java b/opennms-config-model/src/main/java/org/opennms/netmgt/config/poller/BasicSchedule.java index ccab3ca..7f5ccb9 100644 --- a/opennms-config-model/src/main/java/org/opennms/netmgt/config/poller/BasicSchedule.java +++ b/opennms-config-model/src/main/java/org/opennms/netmgt/config/poller/BasicSchedule.java @@ -61,7 +61,13 @@ import org.xml.sax.ContentHandler; @XmlAccessorType(XmlAccessType.FIELD) @ValidateUsing("poll-outages.xsd") public class BasicSchedule implements java.io.Serializable { - private static final long serialVersionUID = 8140458365613931426L; + private static final long serialVersionUID = 8140458365613931427L; + + /** + * outage id + */ + @XmlAttribute(name="id") + private long _id; /** * outage name @@ -85,6 +91,7 @@ public class BasicSchedule implements java.io.Serializable { public BasicSchedule() { super(); this._timeList = new ArrayList