Trailing ", \" in report definitions throws not helpful error message

Description

The error message in output.log which is caused through this config issue:

reports=powerSupplyTable.powerSupplyOutputWatts, \ virtualDiskTable.virtualDiskProgress, \ virtualDiskTable.virtualDiskRemainingRedundancy, \

is not really helpful to find the problem.

horizon | 09:30:18.126 [Main] ERROR org.opennms.netmgt.dao.support.PropertiesGraphDao - Failed to load report '' horizon | org.springframework.dao.DataAccessResourceFailureException: Properties for report '' must contain 'report..name' property horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.getReportProperty(PropertiesGraphDao.java:645) ~[opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.makePrefabGraph(PropertiesGraphDao.java:554) ~[opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.loadPrefabGraphDefinitions(PropertiesGraphDao.java:532) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.loadIncludedFile(PropertiesGraphDao.java:220) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.scanIncludeDirectory(PropertiesGraphDao.java:284) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.createPrefabGraphType(PropertiesGraphDao.java:395) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.createPrefabGraphType(PropertiesGraphDao.java:302) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.loadProperties(PropertiesGraphDao.java:149) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.initPrefab(PropertiesGraphDao.java:98) [opennms-dao-23.0.1.jar:?] horizon | at org.opennms.netmgt.dao.support.PropertiesGraphDao.afterPropertiesSet(PropertiesGraphDao.java:883) [opennms-dao-23.0.1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1642) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1579) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:553) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:482) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197) [org.apache.servicemix.bundles.spring-beans-4.2.9.RELEASE_1.jar:?] horizon | at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1058) [org.apache.servicemix.bundles.spring-context-4.2.9.RELEASE_1.jar:?] horizon | at org.opennms.netmgt.config.tester.ConfigTester.testConfig(ConfigTester.java:89) [opennms-config-tester-23.0.1.jar:?] horizon | at org.opennms.netmgt.config.tester.ConfigTester.testConfig(ConfigTester.java:205) [opennms-config-tester-23.0.1.jar:?] horizon | at org.opennms.netmgt.config.tester.ConfigTester.main(ConfigTester.java:190) [opennms-config-tester-23.0.1.jar:?] horizon | at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_191] horizon | at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_191] horizon | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_191] horizon | at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_191] horizon | at org.opennms.bootstrap.Bootstrap$4.run(Bootstrap.java:525) [opennms_bootstrap.jar:?] horizon | at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]

The message should tell us more information, for example the line number.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Christian Pape July 24, 2020 at 7:10 AM

Merged.

John Blackburn February 26, 2019 at 11:52 PM

The message should also specify the filename, as the snmp-graph.properties.d contains over 100 files

Fixed

Details

Assignee

Reporter

Labels

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created January 15, 2019 at 8:39 AM
Updated July 24, 2020 at 7:10 AM
Resolved July 24, 2020 at 7:10 AM

Flag notifications