Ordering of classification groups does not work

Description

Steps to reproduce:

  • deploy an OpenNMS instance

  • navigate to Admin -> Manage Flow Classification, open Settings tab

  • pre-defined position is set to 0, user-defined position is set to 10

  • the move-icon left of user-defined is useless, you cannot move user-defined up

  • there is no move icon for the pre-defined group. Why?
    -> There is no way to move the pre-defined group down. Is it intended that only user-defined groups can be ordered this way. Is the predefined group alway position 0?

Now:

  • disable group pre-defined and enable group pre-defined again

  • pre-defined position is now set to 1, user-defined position is set to 0

  • the move-icon left of user-defined is useless, you cannot move user-defined down
    -> There is no way to move the user-defined group down. This is also weird, because I have no chance to move the pre-defined group up again.

It seems that the ordering of groups is somehow broken. Even editing an entry doesn't help because you cannot enter the required numbers you need to change the ordering.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Markus von Rüden September 18, 2019 at 11:38 AM

Markus von Rüden September 18, 2019 at 11:28 AM
Edited

The issue here is, that originally the group position was called priority and rules with a higher priority were shown first.
In order to achieve this, the user-defined rules had a priority of 10, whereas the pre-defined rules a priority of 0.

When issue was merged the column was renamed from priority to position.
Also the logic changed to show values with a lower position shows up first in the list.
However, the table classification_groups had still the original values.
Meaning the list is now inverted.

Besides changing the table column from priority to position the table values for position should also be updated.

Fixed

Details

Assignee

Reporter

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created September 17, 2019 at 11:51 AM
Updated September 18, 2019 at 2:59 PM
Resolved September 18, 2019 at 2:59 PM