Fixed
Details
Assignee
Alejandro GalueAlejandro GalueReporter
Alejandro GalueAlejandro GalueHB Grooming Date
May 11, 2021HB Backlog Status
BacklogComponents
Affects versions
Priority
Minor
Details
Details
Assignee
Alejandro Galue
Alejandro GalueReporter
Alejandro Galue
Alejandro GalueHB Grooming Date
May 11, 2021
HB Backlog Status
Backlog
Components
Affects versions
Priority
PagerDuty
PagerDuty
PagerDuty
Created May 7, 2021 at 5:51 PM
Updated November 9, 2021 at 4:16 PM
Resolved November 2, 2021 at 2:15 PM
When I implemented the evaluation layer, the logic to identify nodes versus interfaces was deterministic:
https://github.com/OpenNMS/opennms/blob/master/features/timeseries-evaluate/src/main/java/org/opennms/netmgt/collection/persistence/evaluate/EvaluateStats.java#L142
Unfortunately, that is not the case anymore, as now after all the refactoring made over the years (since the evaluation layer exists), and now "getResource().getParent().getName()" returns something different.
With the current state of the code, I think the checkNode method should receive the CollectionResource entity. There, check the resource type, decide if the resource belongs to Pollerd (interface) or Collectd (node), and increase the appropriate counter.
Currently, both nodes and interfaces are counted as interfaces, and here is how they appear in memory:
The nodes should be agalue-mbp and opennms. The rest are, as you can see, interfaces. Note that "fs/snmp" is not part of the node path identifier anymore. That leads to show the counters as:
Note that "node" has zero, whereas "interfaces" contains the total number of interfaces plus nodes.