Improve handling of invalid IP addresses during provisioning cycle

Description

  1. While invalid IP addresses should not make their way into a requisition, in the case that they do, the provisiond cycle will stop processing subsequent nodes in the requisition. When encountering an invalid IP, that node (or just that IP) should be skipped to allow other nodes in the requisition to complete the import cycle.

  2. When importing a requisition from a non-file source (such as an HTTP location), there should be an additional check for IP validity and omit/log invalid IP addresses to prevent them from being written to the requisition file.

  3. Invalid IP addresses are only written to provisiond.log when in DEBUG mode. Including invalid IP addresses in WARN mode will help users identify the issue in a timely manner. And after PRIS-157 and https://opennms.atlassian.net/browse/NMS-13805#icft=NMS-13805, should have a lower chance of making their way into a requisition.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Alex May February 9, 2022 at 2:56 PM

Jeff Jancula December 8, 2021 at 8:06 PM

security-low label because NMS becomes partially unavailable due to bad IP address.

Fixed

Details

Assignee

Reporter

HB Grooming Date

HB Backlog Status

Story Points

Sprint

Fix versions

Priority

PagerDuty

Created December 2, 2021 at 4:47 PM
Updated March 23, 2022 at 1:52 PM
Resolved March 16, 2022 at 12:50 PM

Flag notifications