XMPPNotificationStrategy (or JavaMailNotificationStrategy) does not utilise the "Numeric Message" field -nm
Description
Environment
Acceptance / Success Criteria
Attachments
Lucidchart Diagrams
Activity
Seth Leger July 8, 2011 at 10:02 PM
commit beb0ae50091e358630c2058d359affd462644f2f
Seth Leger July 8, 2011 at 10:02 PM
I committed this fix in the 1.10 branch. It should go out in the next release candidate of 1.9/1.10.
Jason Long February 19, 2011 at 7:06 PM
Would be great if this also supported -subject.
Jason Long February 15, 2011 at 4:03 AM
+1 on this.. just ran into the same issue.
Patrick Tuite August 27, 2010 at 10:43 AM
Created an attachment (id=1077)
Patch to allow the XMPPNotificationStrategy to also evaluate the Numerical Message switch (-nm) in notificationCommand.xml
Finally got around to checking out OpenNMS source with git and creating a patch for this enhancement. I checked out the current 1.8 branch but I don't think any changes have been made to the code subsequently.
So, this patch will also allow the xmppMessage to evaluate the -nm switch argument to get the body of the Message. This way we can separate fuller HTML style bodies for email messages and terse text message bodies for a jabber client. In our case we use the kopete jabber client on a large display in the NOC with the messages colour coded based on severity for a realtime alarm (notification) monitor and didn't need all the extra links etc, that were in the email notifications showing up there.
I tested this on 1.8.3 and it worked.
There are messaging systems used in Notifcations that can handle richer content than others and you would like to get for instance formatted emails with links back to events or alarms and SMS messages that have a 160 char limit where you need a terse message. You can choose the field to extract the message from when using a Custom NotificationCommmand, like calling a shell script. The predefined Java Notification Strategies have fixed fields for checking for message content. However when you wish to get a rolling list of XMPP Notifications outputted to a large screen in your NOC, you'd like to get short messages as in SMS
Could the predfined Java Notification Strategies such as XMPPNotificationStategy have the private method
private String[] parseArgument(List<Argument> arguments)
be amended to check for the numeric message switch as well? i.e.
private String[] parseArguments(List<Argument> arguments) throws Exception {
String[] parsedArgs = new String[XMPP_MAX];
for (int i = 0; i < arguments.size(); i++) {
Argument arg = arguments.get;
if (NotificationManager.PARAM_XMPP_ADDRESS.equals(arg.getSwitch())) {
parsedArgs[XMPP_TO] = arg.getValue();
} else if (NotificationManager.PARAM_TEXT_MSG.equals(arg.getSwitch())) {
parsedArgs[XMPP_MESSAGE] = arg.getValue();
} else if (NotificationManager.PARAM_NUM_MSG.equals(arg.getSwitch())) {
parsedArgs[XMPP_MESSAGE] = arg.getValue();
}
}
Thanks
Patrick