Node-Availability-Report failing - possibly due to a parameter that should be marked notForPrompting
Description
New JasperReports are failing in my branch with an unsupported parameter type (java.lang.Double). We currently don't support Double (which in itself is relatively easily fixed), but I suspect the parameter should be marked notForPrompting. Causes a ReportException thus:
2010-12-10 16:59:34,479 DEBUG [9602137@qtp-13027694-14] JasperReportService: found promptable report parm AVAILABILITY_WARNING 2010-12-10 16:59:34,479 ERROR [9602137@qtp-13027694-14] DefaultReportWrapperService: Report Exception when retrieving report parameters org.opennms.api.reporting.ReportException: Unsupported report parameter type java.lang.Double at org.opennms.reporting.jasperreports.svclayer.JasperReportService.getParameters(JasperReportService.java:241)
Not terrifically well handled by the webUI (that needs to be fixed too). If the parameters are notForPrompting, they should be marked as such. Also the jasper reports code will not populate defaults as set here. Raising this as a bug as it will be an issue when we merge the rest of feature-report-api-parameters into master. The offending elements in NodeAvailabilityReport.jrxml around line 218:
Suspect that the best way out for this is to add support for java.lang.Double, defaults and better error handling .
Environment
OS X
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Donald Desloge February 7, 2011 at 4:57 PM
Edited
Fixed with the merge of the feature-reporting-api-parameters
Jonathan Sartin January 18, 2011 at 4:20 PM
Should be fixed if you've merged the branch. Feature now supports Double. If in doubt, and you don't need the parameter to be modifiable at runtime, mark it notForPrompting in any case.
Donald Desloge January 18, 2011 at 11:48 AM
Jonathan,
I've recently merged your parameter feature branch into 1.8 and master. I've been testing the reports out and the feature seems pretty solid. Is this issue still a problem or has this been fixed in the latest feature.
All of the reports run in 1.8 and master with your feature. Just wanted to make sure I wasn't missing anything.
New JasperReports are failing in my branch with an unsupported parameter type (java.lang.Double). We currently don't support Double (which in itself is relatively easily fixed), but I suspect the parameter should be marked notForPrompting. Causes a ReportException thus:
2010-12-10 16:59:34,479 DEBUG [9602137@qtp-13027694-14] JasperReportService: found promptable report parm AVAILABILITY_WARNING
2010-12-10 16:59:34,479 ERROR [9602137@qtp-13027694-14] DefaultReportWrapperService: Report Exception when retrieving report parameters
org.opennms.api.reporting.ReportException: Unsupported report parameter type java.lang.Double
at org.opennms.reporting.jasperreports.svclayer.JasperReportService.getParameters(JasperReportService.java:241)
Not terrifically well handled by the webUI (that needs to be fixed too). If the parameters are notForPrompting, they should be marked as such. Also the jasper reports code will not populate defaults as set here. Raising this as a bug as it will be an issue when we merge the rest of feature-report-api-parameters into master. The offending elements in NodeAvailabilityReport.jrxml around line 218:
<parameter name="COMPANY_LOGO" class="java.lang.String">
<defaultValueExpression><![CDATA["/Users/user/git/opennms/target/opennms-1.9.4-SNAPSHOT/etc/report-templates/assets/images/company-logo.png"]]></defaultValueExpression>
</parameter>
<parameter name="SURVEILLANCE_CATEGORY" class="java.lang.String">
<defaultValueExpression><![CDATA["Routers"]]></defaultValueExpression>
</parameter>
<parameter name="AVAILABILITY_WARNING" class="java.lang.Double">
<defaultValueExpression><![CDATA[new Double("98.0")]]></defaultValueExpression>
</parameter>
<parameter name="AVAILABILITY_CRITICAL" class="java.lang.Double">
<defaultValueExpression><![CDATA[new Double("97.0")]]></defaultValueExpression>
</parameter>
<parameter name="TIME_RANGE" class="java.lang.String">
<defaultValueExpression><![CDATA["7 Days"]]></defaultValueExpression>
</parameter>
<parameter name="START_TIME" class="java.sql.Timestamp">
<defaultValueExpression><![CDATA[new java.sql.Timestamp(new java.util.Date().getTime() - (86400 * 7 * 1000))]]></defaultValueExpression>
</parameter>
<parameter name="TIME_RANGE_DESCRIPTION" class="java.lang.String">
<defaultValueExpression><![CDATA[$P{TIME_RANGE} + " from " + $P{START_TIME}]]></defaultValueExpression>
</parameter>
Suspect that the best way out for this is to add support for java.lang.Double, defaults and better error handling .