Make compile.pl / assemble.pl actually exit with maven exit code

Description

"perldoc -f system" says that we should examine $?, not $_

Acceptance / Success Criteria

None

Attachments

1

Lucidchart Diagrams

Activity

Show:

Benjamin Reed February 2, 2011 at 1:28 PM

Whups, needed to resolv this.

Benjamin Reed February 2, 2011 at 1:26 PM

$? should be getting passed to that handle_errors_and_exit method (it's the return value of system()), so that's not the issue. The real issue is $_ is not the first argument to a subroutine, $_[0] is. My perl was rusty.

Fixed now in 1.8 and master

[1.8 339dc61] handle exit value properly
[master 08ebb9a] handle exit value properly

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created January 17, 2011 at 4:54 AM
Updated January 27, 2017 at 4:19 PM
Resolved February 2, 2011 at 1:28 PM