wrong implementation of org.opennms.netmgt.correlation.Correlator$EngineAdapter.getName() ?

Description

the implementation of the above mentioned method goes like this:
return m_engine.getClass().getSimpleName();

AND this will always return "DroolsCorrelationEngine"

So we end having one key for all instantiated Rule Engines.
Perhaps I am wrong, but i did not get events for a rule engine it was interested in, instead another rule engine got them, which was not interested in.
Although the neglected rule engine was somehow registered as event listener.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Matt Brozowski September 16, 2011 at 10:03 PM

Fixed this by including both the engine class name and the engine name so the the EventListener thread should be named something like 'DroolsCorrelationEngine-myEngine'

johannes s September 8, 2011 at 11:04 AM

I changed the implementation from:
return m_engine.getClass().getSimpleName();

TO

return m_engine.getName();

and it works as expected: events are only forwarded to the rule engine interested in.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created September 7, 2011 at 12:09 PM
Updated January 27, 2017 at 4:20 PM
Resolved September 16, 2011 at 10:03 PM