CIDR-notation IP address in linkd causes exception
Description
Somehow linkd scanning is creating an IP address that has a '/22' appended to the end of the address. :-/ It looks like this exception is being caught by the thread pool, indicating that the scan of this node is probably aborting once the error occurs.
2011-11-14 10:12:44,227 WARN [LinkdScheduler-5 Pool-fiber2] HibernateEventWriter: processIpNetToMediaTable: no node found for IP address 74.0.0.54. 2011-11-14 10:12:45,592 WARN [LinkdScheduler-5 Pool-fiber2] HibernateEventWriter: processDot1DBase: Invalid base bridge address: null 2011-11-14 10:12:45,901 ERROR [LinkdScheduler-5 Pool-fiber2] RunnableConsumerThreadPool$FiberThreadImpl: No error listeners defined for unexpected error: java.lang.IllegalArgumentException: Invalid IPAddress 10.0.0.0/22 java.lang.IllegalArgumentException: Invalid IPAddress 10.0.0.0/22 at org.opennms.core.utils.InetAddressUtils.getInetAddress(InetAddressUtils.java:152) at org.opennms.netmgt.linkd.RouterInterface.<init>(RouterInterface.java:50) at org.opennms.netmgt.linkd.HibernateEventWriter.getNodeidMaskFromIp(HibernateEventWriter.java:418) at org.opennms.netmgt.linkd.AbstractQueryManager.processRouteTable(AbstractQueryManager.java:308) at org.opennms.netmgt.linkd.HibernateEventWriter.storeSnmpCollection(HibernateEventWriter.java:206) at org.opennms.netmgt.linkd.Linkd.updateNodeSnmpCollection(Linkd.java:572) at org.opennms.netmgt.linkd.SnmpCollection.run(SnmpCollection.java:522) at org.opennms.netmgt.linkd.scheduler.Scheduler$1.run(Scheduler.java:301) at org.opennms.core.concurrent.RunnableConsumerThreadPool$FiberThreadImpl.run(RunnableConsumerThreadPool.java:420) at java.lang.Thread.run(Thread.java:662) 2011-11-14 10:12:54,181 WARN [LinkdScheduler-5 Pool-fiber1] HibernateEventWriter: processIpNetToMediaTable: no node found for IP address 64.0.0.137.
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Seth Leger December 6, 2011 at 1:41 PM
I've changed the netmask fields to always be represented by an IP address (instead of the CIDR network notation). This matches the values in the snmpinterface tables and allows the OnmsSnmpInterface object and DAO to be reused by linkd. Marking as fixed.
commit 76f84f6dd8d4c58f5dc2d41aa0dcfd29e919c48f
Seth Leger December 5, 2011 at 3:41 PM
Actually, the problem is inside IPAddressTableTracker.getNetMask(), it formats the netmask fields in the manner that is described in this bug. I'm working on fixing this now.
Seth Leger December 5, 2011 at 3:30 PM
Actually, now that I look at the code, it appears that this error is happening because the snmpipadentnetmask field in the database contains the erroneous string value. I'm going to assume that the contents of this table were provisioned incorrectly with the CIDR value instead of the normal dotted-quad value. Marking as invalid. To test to see if this problem affects your system, please run the following query and then correct the values in any rows that it finds:
Somehow linkd scanning is creating an IP address that has a '/22' appended to the end of the address. :-/ It looks like this exception is being caught by the thread pool, indicating that the scan of this node is probably aborting once the error occurs.
2011-11-14 10:12:44,227 WARN [LinkdScheduler-5 Pool-fiber2] HibernateEventWriter: processIpNetToMediaTable: no node found for IP address 74.0.0.54.
2011-11-14 10:12:45,592 WARN [LinkdScheduler-5 Pool-fiber2] HibernateEventWriter: processDot1DBase: Invalid base bridge address: null
2011-11-14 10:12:45,901 ERROR [LinkdScheduler-5 Pool-fiber2] RunnableConsumerThreadPool$FiberThreadImpl: No error listeners defined for unexpected error: java.lang.IllegalArgumentException: Invalid IPAddress 10.0.0.0/22
java.lang.IllegalArgumentException: Invalid IPAddress 10.0.0.0/22
at org.opennms.core.utils.InetAddressUtils.getInetAddress(InetAddressUtils.java:152)
at org.opennms.netmgt.linkd.RouterInterface.<init>(RouterInterface.java:50)
at org.opennms.netmgt.linkd.HibernateEventWriter.getNodeidMaskFromIp(HibernateEventWriter.java:418)
at org.opennms.netmgt.linkd.AbstractQueryManager.processRouteTable(AbstractQueryManager.java:308)
at org.opennms.netmgt.linkd.HibernateEventWriter.storeSnmpCollection(HibernateEventWriter.java:206)
at org.opennms.netmgt.linkd.Linkd.updateNodeSnmpCollection(Linkd.java:572)
at org.opennms.netmgt.linkd.SnmpCollection.run(SnmpCollection.java:522)
at org.opennms.netmgt.linkd.scheduler.Scheduler$1.run(Scheduler.java:301)
at org.opennms.core.concurrent.RunnableConsumerThreadPool$FiberThreadImpl.run(RunnableConsumerThreadPool.java:420)
at java.lang.Thread.run(Thread.java:662)
2011-11-14 10:12:54,181 WARN [LinkdScheduler-5 Pool-fiber1] HibernateEventWriter: processIpNetToMediaTable: no node found for IP address 64.0.0.137.