Notification names cannot contain an apostrophe it breaks the Java script

Description

The radio and edit buttons don't work when you have an apostrophe in the name of the notification you've created... (Dr., it hurts when I do this..)

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Alejandro Galue December 21, 2011 at 12:15 PM

The problem is that the JavaScript expects that the string is properly escaped, otherwise the generated code will looks like this:

Instead of:

I've used org.apache.commons.lang.StringEscapeUtils.escapeJavaScript to fix the problem.

Fixed on revision ac589099ce611b4810867101f31298cad9cdc031 for 1.10.
Fixed on revision a4e6fa69ad0312da6ad77f105d47fda3cf1eb312 for 1.8.

David Hustace December 7, 2011 at 1:43 PM

I know Donald is busy, reassigning to Matt for his delegation.

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

PagerDuty

Created December 7, 2011 at 1:42 PM
Updated January 27, 2017 at 4:21 PM
Resolved December 21, 2011 at 12:15 PM