The Poll Snmp Interface Policy is overwritten if the interface has a valid ip address

Description

See customer ticket https://mynms.opennms.com/Ticket/Display.html?id=1371

The Snmp poller in 1.10+ is configured using a SnmpInterfacePolicy.
It is possible to specify as the action of the policy Poll.

This will set the snmpPoll from N (Not Polled ---the default value) to P (Poll).
The snmppoller now looks into the database to check the interface to poll.

So if I want to poll and Snmp Interface I have to set up a specifi SnmpInterfacePolicy to poll the specified interface.

What happens is that when this interface has an ip address then the "Policy rule" is overwritten to default policy (Not poll).

Environment

Detected on linux ubunto jvm 6 but should not depend on environment

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Benjamin Reed July 9, 2012 at 4:49 PM

Correct, I was referring to the changes as a whole, not just the addition of a test. The changes related to this bug are too big to backport to 1.10.

Antonio Russo July 9, 2012 at 4:35 PM

It is this commit where I changed the Model:

commit 9e68a4595ca9e762a60c2b5ce26fe99cfb9de748
Author: Antonio <rssntn67@yahoo.it>
Date: Mon Jul 9 15:00:25 2012 +0200

Created REST service for datalinkinterface

First step to create a Linkd TopologyProvider
that will use our REST interface to get
the links: let the links available on the REST interface

But this is related to the new Topology Provider based on linkd, and it is completely another thing.
The current bug was related to a customer TT. The commit specified in this comment is a first step
to get TopologyProvider work over our rest interface.

Antonio Russo July 9, 2012 at 4:32 PM

Ben, no changes to model here.
I've only added a test.

commit fa3c9f07058a1628bfec2ca6b2d48d3800dfffdb
Author: Antonio <rssntn67@yahoo.it>
Date: Mon Jul 9 20:36:35 2012 +0200

Resolved https://opennms.atlassian.net/browse/NMS-5425#icft=NMS-5425

Set the ENABLE_SNMP_POLL in MatchingIpInterfacepolicy

commit 89303fbef6ae05590d4e8283340ae191b79bdea4
Author: Antonio <rssntn67@yahoo.it>
Date: Mon Jul 9 19:36:19 2012 +0200

Added a test for https://opennms.atlassian.net/browse/NMS-5425#icft=NMS-5425

Setting a MatchingSnmpInterfacePolicy to
poll SnmpInterface does not work
when the interface has a valid ip address

And if you hit git show you have only the test opennms-provision/opennms-provisiond/src/test/java/org/opennms/netmgt/provision/service/PolicyTest.java.

Benjamin Reed July 9, 2012 at 3:06 PM

actually, considering the changes (model changes to OnmsSnmpInterface) I'm thinking this shouldn't be in 1.10, we'll let it get some testing before going into 1.12. I'll change the fix version.

Benjamin Reed July 9, 2012 at 2:57 PM

Antonio, I see you marked this as fixed for 1.10 and 1.11, but you only committed to master. Should this fix be cherry-picked back to 1.10?

Fixed

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

PagerDuty

Created July 9, 2012 at 9:28 AM
Updated July 9, 2012 at 6:36 PM
Resolved July 9, 2012 at 2:38 PM

Flag notifications