NCS configuration file found in 1.12 branch

Description

The ncs-northbounder-configuration.xml should not be in the release.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Benjamin Reed July 19, 2013 at 1:30 PM

I've cleaned up the packaging in 1.12 and merged it forward to master. After talking with Matt, I went ahead and left the event conf in.

Benjamin Reed July 19, 2013 at 9:45 AM

OK, most of the files you listed are already split out into the opennms-ncs RPM/deb.

  • I've removed the event file from the default eventconf, and put it into the opennms-ncs package, with a note in the package description that you have to re-add it into eventconf if you're using NCS. We'll have to tell Juniper about this so when they merge from master they re-add it to their default config.

  • I moved the system/ jars into the NCS package as well.

  • I changed it so that opennms-ncs owns the drools ncs directory; the files were already getting put in the NCS RPM, but the directory still existed in opennms-core.

Question; is there any reason not to just leave the events file enabled and installed by default? It doesn't really hurt anything other than taking up a couple kilobytes of memory... Then we don't have to have the "hand-add this thing to your eventconf!" thing.

Benjamin Reed July 19, 2013 at 9:31 AM

Ah yes, if they're not in the RPM that's a bug, I'll look into that today.

Matt Brozowski July 19, 2013 at 9:18 AM

Also I don't think opencsv has anything to do with ncs.

Matt Brozowski July 19, 2013 at 9:17 AM

I don't think there is a licensing reason but we do have an ncs rpm... shouldn't they be part of that? I'm am pretty sure that the ncs stuff when installed is activated so we should definitely avoid installing it if it isn't intended to be activated. The only exceptions in my mind would be the events file since there is no easy way to inject them into eventconf (in fact I think they are in base-assembly for that reason)

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created July 19, 2013 at 5:53 AM
Updated January 27, 2017 at 4:20 PM
Resolved July 19, 2013 at 1:30 PM