Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

VmwareConfigBuilder is not generating a valid graph templates file.

Description

After auto generate the configuration files for the VMWare collector, there are some issues that prevents the correct parsing of the graph templates.

1) The last element of the template list, should not contain ", \", for example:
...
vmware5.DaStTlRdLyAvg, \ vmware5.DaStTlWeLyAvg, \ vmware5.DaStWeAvg, \
report.vmware5.CpuCoreUnAvg.name=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.columns=CpuCoreUnAvg
...

It should be:
...
vmware5.DaStTlRdLyAvg, \ vmware5.DaStTlWeLyAvg, \ vmware5.DaStWeAvg

report.vmware5.CpuCoreUnAvg.name=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.columns=CpuCoreUnAvg
...

2) The last line of the graph template definition should not end with "\", for example:

report.vmware5.CpuCoreUnAvg.name=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.columns=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.propertiesValues=vmware5CpuName
report.vmware5.CpuCoreUnAvg.type=vmware5Cpu
report.vmware5.CpuCoreUnAvg.command=--title="CpuCoreUnAvg {vmware5CpuName}" \ --vertical-label="CpuCoreUnAvg" \ DEF:xxx={rrd1}:CpuCoreUnAvg:AVERAGE \ LINE2:xxx#0000ff:"CpuCoreUnAvg" \ GPRINT:xxx:AVERAGE:"Avg
: %8.2lf %s" \ GPRINT:xxx:MIN:"Min
: %8.2lf %s" \ GPRINT:xxx:MAX:"Max
: %8.2lf %s
n" \
It should be:

report.vmware5.CpuCoreUnAvg.name=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.columns=CpuCoreUnAvg
report.vmware5.CpuCoreUnAvg.propertiesValues=vmware5CpuName
report.vmware5.CpuCoreUnAvg.type=vmware5Cpu
report.vmware5.CpuCoreUnAvg.command=--title="CpuCoreUnAvg {vmware5CpuName}" \ --vertical-label="CpuCoreUnAvg" \ DEF:xxx={rrd1}:CpuCoreUnAvg:AVERAGE \ LINE2:xxx#0000ff:"CpuCoreUnAvg" \ GPRINT:xxx:AVERAGE:"Avg
: %8.2lf %s" \ GPRINT:xxx:MIN:"Min
: %8.2lf %s" \ GPRINT:xxx:MAX:"Max
: %8.2lf %s
n"

Environment

OpenNMS 1.12.0 Installed on CentOS 6.4 x86_64 through RPMs.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Christian Pape August 30, 2013 at 4:59 AM

Cherrypicked to master with commit 2cfd7f49dc2a767bb9b67cd560da9aae146aa6af

Alejandro Galue August 29, 2013 at 3:07 PM

Fixed on revision 40a37014e1c675759b400867e94b4e6f3be13e96 for 1.12

Alejandro Galue August 29, 2013 at 3:05 PM

Finally, the templates could display a better information on it's name and the graph title, for example:

Is definitively better than:

Pay special attention to the template's name and the title on the command.

Alejandro Galue August 29, 2013 at 2:50 PM

I discovered that there is duplicate data on the auto-generated graph templates file, so the internal algorithm to determinate if each discovered metric was processed or not is not correct.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created August 29, 2013 at 2:26 PM
Updated January 27, 2017 at 4:21 PM
Resolved August 29, 2013 at 3:07 PM