provision.pl does not import requisitions with spaces in the name

Description

provision.pl appears to handle the provisioning process of a requisition that contains spaces in its name up until you attempt to commit it with "requisition import ..."

It fails with a 500 Server Error, but stages the requisition in imports/pending, at which point the user must import/sync it with the GUI.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Alejandro Galue March 29, 2016 at 11:50 AM

Thanks to f068cdb5fb07488dd7f09d249fd4b95be4002e63 (on foundation-2016), I think that should fix the problem with provision.pl. In fact, the problem was a server side class responsible for managing the requisition changes through the ReST API. As I fixed that for the new requisitions UI, that should not be a problem for provision.pl

Peter Petrov July 29, 2014 at 5:29 AM

Thank you for your answer. This is what I expect. In my opinion your answer resolve this issue.

Alejandro Galue July 28, 2014 at 9:49 AM

The critical parameters of a requisitioned node are the foreign source (a.k.a the name of the requisition), and the foreign ID (the unique ID within the requisition for a node).

The node's label is just for description and search purposes, I don't see why you can't use spaces on this particular field.

Category names, are another example of important fields that should not contain spaces or special characters (with just one exception: "-"), because that will limit the ability to use the "catinc" keyword on filters:

http://www.opennms.org/wiki/Filters

Peter Petrov July 27, 2014 at 4:50 AM

Mr. Galue, it's recommended or not to use spaces in node-label only?

Alejandro Galue July 24, 2014 at 9:17 AM

The correct behavior should be, update the ReST API and the WebUI to reject the name of a requisition or a foreign ID when they have special characters.

Fixed

Details

Assignee

Reporter

Affects versions

Priority

PagerDuty

Created January 18, 2014 at 8:00 PM
Updated April 15, 2016 at 3:02 PM
Resolved April 15, 2016 at 3:02 PM

Flag notifications