snmp mib compiler should use twin column select for systemDefs
Description
Acceptance / Success Criteria
Lucidchart Diagrams
Activity
Alejandro Galue April 24, 2014 at 1:24 PM
Fixed on revision 750b55eeffae098e9122ba0c5839722eeb990fe1 on master.
Indeed the trick is assume that getValue() returns a Set and setValue() expects a set.
Alejandro Galue April 24, 2014 at 1:09 PM
OMG, another item for the big list about why I hate Vaadin ...
So, getValue() returns an object, but in this particular case, the object is a Set, so you should explicitly cast this to a Set and then use it
Of course, setValue() expects a Set as well.
I need to test it to see if this make sense ...
Alejandro Galue April 24, 2014 at 12:48 PM
I know. That component exist in both versions of Vaadin, but the WebUI in OpenNMS is completely different, so implement this for 1.12 and master means work twice, and almost nothing can be reused (in other words, never merge a change done for 1.12 into master if it is related with Vaadin)
My issues with the TwinColumn, is how to put the available groups and the selected groups programmatically. I know how to fill the "available" but I don't know how to retrieve the selected groups or how to set the selected groups programmatically (I mean in Java, not from the WebUI).
When the custom field called CollectField is initialized, all the available groups should appear on the "left" side of the TwinColumn, that's fine. Then, the currently configured groups must appear on the "right" side, how can I do that ? Then, I'm not sure how to retrieve the "selected data" in order to build org.opennms.netmgt.config.datacollection.Collect and also not sure how to set the "selected data" when parsing org.opennms.netmgt.config.datacollection.Collect.
Makes sense ?
That's why I didn't use this component in the first place.
If that can be done, I'll be happy to fix it.
Ron Roskens April 24, 2014 at 12:39 PM
TwinColSelect is also in vaadin 6. (section 5.13.6)
http://demo.vaadin.com/book-examples/book/#component.select.twincolselect.basic
Alejandro Galue April 24, 2014 at 12:24 PM
Keep in mind that 1.12 uses Vaadin 6 and 1.13 (master) uses Vaadin 7, and they are NOT compatible
So, I think the solution for this may go only in master (as this is an enhancement).
Here is my doubt: I'm not sure if TwinColSelect is as flexible and powerful, and provide the same features as a Combo field. If so, I can give it a try
When you are adding a new system definition details for a data collection group, the UI picker is a bit clunky to work with if you want to add or remove multiple mib groups.
What would make this ui action in the snmp mib compiler easier is Vaadin's Twin Column Select (TwinColSelect).
https://vaadin.com/book/-/page/components.selecting.html
5.15.6. Twin Column Selection with TwinColSelect
This way it would also enforce uniqueness in that you can only add an entry once to the mib group list.