vmware urls do not support username/passwords that require URL encoding

Description

If you have a username & password for vmware that requires it to be encoded for use in a URL, vmwarereqtool will give you an empty requisition when it is unable to login to vcenter.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Markus von Rüden January 30, 2017 at 4:40 AM

Cyrille Bollu December 12, 2016 at 10:24 AM

Change is ok for me.

I've built it against 18.0.1 (./compile.pl -DskipTests) and tested the new .jar on my production system.

I need some review here

Cyrille Bollu December 12, 2016 at 6:16 AM

Cyrille Bollu December 5, 2016 at 7:56 AM

I think the problem starts in the VmwareRequisitionTool where a java.net.URL object is constructed from the requisition's import-url-resource parameter whereas a java.net.URI would probably handle this situation properly

https://docs.oracle.com/javase/7/docs/api/java/net/URI.html

Cyrille Bollu December 5, 2016 at 7:53 AM

Also applicable to VMware provisioning integration: Don't try to put any RFC 2396 reserved character in your username or password in file provisiond-configuration.xml

Fixed

Details

Assignee

Reporter

Components

Sprint

Affects versions

Priority

PagerDuty

Created April 28, 2014 at 4:45 PM
Updated January 31, 2017 at 10:40 AM
Resolved January 30, 2017 at 8:37 AM