Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Problem with disable-ssl-verification in XML_Collector

Description

I have set up the source in xml-datacollection-config.xml as follows:

<xml-source url="https://{ipaddr}/varnishstats/varnishstats.php"> <request method="GET"> <parameter name="timeout" value="6000" /> <parameter name="retries" value="2" /> <parameter name="disable-ssl-verification" value="true" /> </request> ...

The configuration works fine if I use HTTP, but the verification fails if I use HTTPS even though I have set:

<parametername="disable-ssl-verification" value="true" />

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Alejandro Galue June 20, 2014 at 10:29 AM

Fixed on revision aa378a9eef664990a94dde12f9ad4f7ac9b4d50f for 1.12

Craig Gallen June 19, 2014 at 5:09 PM
Edited

From Alejandro;
Checking the code I've found that the parameter verification is not correct, so this is a bug.

The code has:

String disableSslVerification = m_request.getParameter("disable-ssl-verification"); if (Boolean.getBoolean(disableSslVerification)) {

It should be:

String disableSslVerification = m_request.getParameter("disable-ssl-verification"); if (Boolean.parseBoolean(disableSslVerification)) {
Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created June 19, 2014 at 5:07 PM
Updated January 27, 2017 at 4:20 PM
Resolved June 20, 2014 at 10:29 AM

Flag notifications