The issue was fixed:
https://github.com/OpenNMS/opennms/pull/116

Makes sense to me, thanks!

Hey @Alejandro Galue, thanks for your review.

I removed the "Select / Deselect all" links when you are logged in as a read only user. I removed the column with the checbox as well.

I checked if the KSC Reports do have a verification that read only users cannot perform edit/delete actions on controller level
It seems that there is none.
I decided to not implement that, because it is not possible from the UI.
However we may address this in the future. I therefore created a new issue --> https://opennms.atlassian.net/browse/NMS-6943#icft=NMS-6943

I've compiled the branch and I did the following to test the solution:

1) Adding some nodes to the DB
2) Create a user
3) Make the user read-only (by manually modifying magic-users.properties)
4) Use the admin account to create a report stored on disk, and a scheduled report.
5) Login with the RO user
6) I can't see the delete links (which is OK) when displaying the generated reports, and when displaying the scheduled reports.

Suggestion:

The "Select all / Deselect all" should be hidden because that option makes sense only if you are going to remove saved reports or deactivate scheduled reports. For the same reason, the select column with the checkbox should be hidden as well.

About KSC Reports:

The UI of the KSC reports is correct for read-only users, I mean, it only displays the option to view the report and nothing else. But it would be useful to verify that the controller doesn't allow to edit or delete the KSC report to read-only users.

Hey Alejandro,

as mentioned earlier, can you please review this issue.

From my perspective it should now not be able to delete/unschedule reports.
I also beautified the ui a bit but not fully.

Stuff you may need:

• branch name jira/https://opennms.atlassian.net/browse/NMS-6839#icft=NMS-6839

• pull request https://github.com/OpenNMS/opennms/pull/116

• bamboo: http://bamboo.internal.opennms.com:8085/browse/OPENNMS-NMS82

Let me know if you need anything else