Atlassian uses cookies to improve your browsing experience, perform analytics and research, and conduct advertising. Accept all cookies to indicate that you agree to our use of cookies on your device. Atlassian cookies and tracking notice, (opens new window)
Audit HttpClient usage to make sure connections are being closed properly
Description
In the process of fixing https://opennms.atlassian.net/browse/NMS-7121#icft=NMS-7121 I found an additional problem trying to create a ticket from the UI. Our HttpClient usage was modeled on older HttpClient versions, and we're not closing connections properly. I'm going to audit our HttpClient usage to fix this, and fix it anywhere else we may need to.
Acceptance / Success Criteria
None
Lucidchart Diagrams
Activity
Show:
Benjamin Reed November 2, 2014 at 11:23 AM
The original issue I ran into was when attempting to create a ticket through the RT ticketer.
The patch that I made for this is, I think, good, but touches WAY too much code, and I just don't trust changing things this much right before release, so I've made a smaller version that still includes my new HttpClientWrapper API, but only the RT ticketer is using it. That got merged to 14, and then the full patch got merged to develop.
In the process of fixing https://opennms.atlassian.net/browse/NMS-7121#icft=NMS-7121 I found an additional problem trying to create a ticket from the UI. Our HttpClient usage was modeled on older HttpClient versions, and we're not closing connections properly. I'm going to audit our HttpClient usage to fix this, and fix it anywhere else we may need to.