Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Enlinkd Topology Plugin fails to create LLDP links for mismatched link port descriptions.

Description

Some Adtran and Brocade network equipment is not sharing remote port description for LLDP neighbors through SNMP. They appear to not store remote port description at all. Some other models do not advertise remote port description.

In features/topology-map/plugins/org.opennms.features.topology.plugins.topo.linkd/src/main/java/org/opennms/features/topology/plugins/topo/linkd/internal/EnhancedLinkdTopologyProvider.java removing the "bool2" check from getLldpLinks() resolves this problem.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Antonio Russo December 2, 2015 at 12:54 PM

Merged in Foundation

Antonio Russo December 2, 2015 at 6:59 AM

MacBook-Pro-di-Antonio-Russo:opennms antonio$ git commit -a
[features/foundation-enlinkd 5edb589] Fix : Enlinkd Topology Plugin fails to create LLDP links for mismatched link port descriptions.
1 file changed, 1 insertion, 2 deletions
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git push
Counting objects: 81, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (10/10), done.
Writing objects: 100% (18/18), 1.16 KiB | 0 bytes/s, done.
Total 18 (delta 7), reused 0 (delta 0)
To git@github.com:OpenNMS/opennms.git
28c6331..5edb589 features/foundation-enlinkd -> features/foundation-enlinkd

Antonio Russo November 25, 2015 at 1:46 AM

Matt, is this still a problem, I have fixed this in opennms horizin 16

Antonio Russo March 6, 2015 at 8:12 AM

Donald, I'd like to make this changes but I want to discuss with you before

Antonio Russo March 6, 2015 at 8:12 AM

I guess that this must be done according with Donald:

IMO there are too many checks. We need to state a minimal condition set to get an LLDP Link.

Consider we have two nodes. Say Source and Target with an lldp link.
When everything is nice, you should have two row in lldplink table, or two LldpLink objects.
First you have to identify the node, by chassisid and chassisidsubtype, so.....one condition seems lost...because we do not have a boolean for chassisidsubtype. Then you have to identify the port...and this must be done by portid and portidsubtype.

You do not need to check the portDescr.

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

PagerDuty

Created November 5, 2014 at 9:19 AM
Updated December 2, 2015 at 12:54 PM
Resolved December 2, 2015 at 12:54 PM