Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SNMP version syntax inconsistent across components

Description

I just learned that some SNMP-speaking components (SnmpDetector, DiskUsageDetector, others) expect SNMP versions to be specified only in the form "snmpv1" / "snmpv2" / "snmpv2c" / "snmpv3". This deviates from what I thought I knew, which is that "v1" / "v2c" or "v2" / "v3" is correct everywhere.

It appears this pattern was copied over more or less directly from the old equivalent Capsd plugins.

We should normalize every component that allows specifying an SNMP version to accept at least the short forms ("v3" and so on). Probably best to continue recognizing "snmpv3" etc. where it's currently recognized. Not sure whether we should start to allow the long form in places where it's not historically been recognized.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Seth Leger April 9, 2015 at 4:06 PM

Fixed this by allowing v1, v2, v2c, and v3 as SNMP version parameters in these classes. Marking as fixed.

commit e5b82c47403198ade6eed73bbdfe9ebb6b2f7c42

Seth Leger April 9, 2015 at 3:30 PM

This behavior is in:

integrations/opennms-link-provisioning-adapter/src/main/java/org/opennms/netmgt/provision/detector/endpoint/EndPointDetector.java opennms-provision/opennms-detector-simple/src/main/java/org/opennms/netmgt/provision/detector/snmp/SnmpDetector.java opennms-provision/opennms-detector-simple/src/main/java/org/opennms/netmgt/provision/detector/snmp/DiskUsageDetector.java
Fixed

Details

Assignee

Reporter

Labels

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created February 27, 2015 at 11:18 AM
Updated May 11, 2015 at 2:49 PM
Resolved April 9, 2015 at 4:06 PM

Flag notifications