Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Upgrade PostgreSQL Driver and C3P0

Description

We're using a very old driver for PostgreSQL as well as a very old version for C3P0.

Latest C3P0 supports JDBC4:

https://github.com/swaldman/c3p0/blob/01a28e054765c1d254f1cbc82ce55f0632a883ce/src/dist-static/RELEASE_NOTES-c3p0-0.9.5

That means, we can use latest PostgreSQL Driver in OpenNMS if we upgrade both libraries.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Benjamin Reed May 25, 2016 at 9:37 AM

Yeah, I guess the only reason you wouldn't is if someone who doesn't know any better tried messing with a config and set it low. But I'm guessing the chances on that at this point are pretty slim. And now, hopefully, the new c3p0 doesn't have the bug so... seems fine to me.

Alejandro Galue May 25, 2016 at 9:34 AM

Got it!

As we can always put the same numbers on opennms-datasources.xml, I don't think it makes sense to enforce that rule on code. So, I'm planning to set the limits accordingly, and use the configuration to make them equal. In other words:

@Override public void setMinPool(final int minPool) { m_pool.setMinPoolSize(minPool); } @Override public void setMaxPool(final int maxPool) { m_pool.setMaxPoolSize(maxPool); } @Override public void setMaxSize(final int maxSize) { LOG.debug("C3P0 has no equivalent to setMaxSize(). Ignoring."); }

Benjamin Reed May 25, 2016 at 9:29 AM

As for the minpool/maxpool thing in c3p0, I forget the exact bug but it was something about certain pooled connections getting stuck as part of the create/teardown process, and the only way to fix it was to just make sure c3p0 always had a fixed pool. [citation needed]

Alejandro Galue May 24, 2016 at 1:54 PM

Alejandro Galue May 24, 2016 at 1:53 PM

Ben has patched liquibase to avoid errors. I tested it manually and it works perfect. Bamboo is also able to pass without issues as well.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created May 19, 2016 at 11:09 AM
Updated May 26, 2016 at 1:48 AM
Resolved May 25, 2016 at 9:48 PM

Flag notifications