Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Cannot add custom icon key mapping files

Description

The documentations suggests that adding a new file named org.opennms.features.topology.app.icons.custom.cfg in etc/ with custom icon mappings should work, but these files are never loaded, and the icon mappings are not registered.

In order to add custom icon mappings, you currently need to modify one of the existing files instead.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Jesse White June 1, 2016 at 9:10 AM

It turns out that custom "icon key -> icon id" are not required when adding new .svg files. In most cases it is sufficient to add the "icon id" to the icons.list file in order to make the icons accessible via the "Choose Icon" modal.

Markus von Rüden June 1, 2016 at 5:35 AM

Markus von Rüden May 30, 2016 at 4:45 AM
Edited

Each TopologyProvider MUST implement a IconRepository which must point to the file name "org.opennms.features.topology.app.icons.custom.cfg" in order to get the icons work. For GraphML this is currently not done. My assumption was, that if no Icon Mapping exists, the "icon id" is just returned, but a default icon is returned instead.
I think we have to implement a "Dummy" IconManager which - in case of GraphML - just returns the iconKey. In addition each TopologyProvider must define if it supports icon changing (which should be disabled for GraphML)

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

Parent

PagerDuty

Created May 27, 2016 at 8:13 AM
Updated January 27, 2017 at 6:01 PM
Resolved June 3, 2016 at 6:24 PM