Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

opennms-webapp updates javascript dependencies on each build

Description

When building the develop branch, the following files are modified during the build process:

Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: opennms-webapp/src/main/webapp/lib/angular-animate/angular-animate.js modified: opennms-webapp/src/main/webapp/lib/angular-bootstrap/ui-bootstrap-tpls.js modified: opennms-webapp/src/main/webapp/lib/angular-cookies/angular-cookies.js modified: opennms-webapp/src/main/webapp/lib/angular-resource/angular-resource.js modified: opennms-webapp/src/main/webapp/lib/angular-route/angular-route.js modified: opennms-webapp/src/main/webapp/lib/angular-sanitize/angular-sanitize.js modified: opennms-webapp/src/main/webapp/lib/angular/angular.js modified: opennms-webapp/src/main/webapp/lib/font-awesome/css/font-awesome.css modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/FontAwesome.otf modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/fontawesome-webfont.eot modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/fontawesome-webfont.svg modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/fontawesome-webfont.ttf modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/fontawesome-webfont.woff modified: opennms-webapp/src/main/webapp/lib/font-awesome/fonts/fontawesome-webfont.woff2 modified: opennms-webapp/src/main/webapp/lib/jquery-ui/jquery-ui.js modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/accordion.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/all.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/autocomplete.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/base.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/button.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/checkboxradio.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/controlgroup.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/core.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/datepicker.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/dialog.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/draggable.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_444444_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_555555_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_777620_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_777777_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_cc0000_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/images/ui-icons_ffffff_256x240.png modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/jquery-ui.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/jquery-ui.min.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/menu.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/progressbar.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/resizable.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/selectable.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/selectmenu.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/slider.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/sortable.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/spinner.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/tabs.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/theme.css modified: opennms-webapp/src/main/webapp/lib/jquery-ui/themes/base/tooltip.css modified: opennms-webapp/src/main/webapp/lib/requirejs/require.js

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Seth Leger January 26, 2017 at 4:09 PM

Ben changed the build so that it pins the versions as Alejandro recommended. Marking as fixed.

commit 6a4b6457691952d2b28ef7b41c98349d334762c5

Alejandro Galue November 30, 2016 at 2:08 PM

For 19.0.0, I think we should just fix bower.json to use a specific version for each library and avoid auto-updates. For example, we have:

"angular": "^1.5.8",

That means, if 1.5.9 comes one, bower will update the libraries (BTW, 1.5.9 is the latest version). The reason is the "^" in front of the version (which is based on the semantic version concept).

To understand semantic version, try this: https://semver.npmjs.com/

To avoid that, we should just use a specific version, for example:

"angular": "1.5.8",

That should solves the problem. I can do this and target 19.0.0 if this sounds reasonable. In fact we should do the same on packages.json

Seth Leger November 30, 2016 at 12:11 PM

What do you think should be the correct behavior here? Perhaps we shouldn't run the JS updates unless explicitly requested since we do have the JS files checked into the source tree.

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

PagerDuty

Created November 27, 2016 at 4:16 PM
Updated January 26, 2017 at 4:09 PM
Resolved January 26, 2017 at 4:09 PM

Flag notifications