Enlinkd Not Performing Bridge Topology Discovery
Description
Acceptance / Success Criteria
Lucidchart Diagrams
Activity
Antonio Russo December 29, 2016 at 5:35 AM
Merged in foundation 2016
Antonio Russo December 22, 2016 at 1:04 PM
commit a766233e34f4c883d3a8e42d31489bdbb877597a
Author: Antonio <rssntn67@yahoo.it>
Date: Thu Dec 22 18:37:13 2016 +0100
https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964: Enlinkd Not Performing Bridge Topology Discovery
Fixed Null Pointer Exceptions
The Topolgy Discovery is scheduled only if there is
a not 0 bridge forwarding table is available
deleteNode for enlinkd is improved
Improved the scheduler to print statistics
Also checked that the BridgeTopology calculation
is done only if maxbft allows it
Antonio Russo December 22, 2016 at 1:02 PM
Created a branch from foundation-2016
MacBook-Pro-di-Antonio-Russo:opennms antonio$ git push -u origin jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964:jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964
Counting objects: 170, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (43/43), done.
Writing objects: 100% (48/48), 6.87 KiB | 0 bytes/s, done.
Total 48 (delta 24), reused 0 (delta 0)
remote: Resolving deltas: 100% (24/24), completed with 15 local objects.
To git@github.com:OpenNMS/opennms.git
[new branch] jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964 -> jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964
Branch jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964 set up to track remote branch jira/https://opennms.atlassian.net/browse/NMS-8964#icft=NMS-8964 from origin
Created pull request:
Details
Assignee
Antonio RussoAntonio RussoReporter
Antonio RussoAntonio RussoComponents
Fix versions
Affects versions
Priority
Blocker
Details
Details
Assignee
Reporter
Components
Fix versions
Affects versions
Priority
PagerDuty
PagerDuty Incident
PagerDuty
PagerDuty Incident
PagerDuty

I set up Bridge Link Discovery in a Run time env.
I got the following exception in output.log
Exception in thread "Scheduler-Thread-3-of-5" java.lang.NullPointerException
at org.opennms.netmgt.enlinkd.NodeDiscoveryBridgeTopology.run(NodeDiscoveryBridgeTopology.java:498)
at org.opennms.netmgt.enlinkd.scheduler.Scheduler$1.run(Scheduler.java:209)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.opennms.core.concurrent.LogPreservingThreadFactory$3.run(LogPreservingThreadFactory.java:124)
at java.lang.Thread.run(Thread.java:745)
Exception in thread "Scheduler-Thread-6-of-5" java.lang.NullPointerException
at org.opennms.netmgt.enlinkd.NodeDiscoveryBridgeTopology.run(NodeDiscoveryBridgeTopology.java:498)
at org.opennms.netmgt.enlinkd.scheduler.Scheduler$1.run(Scheduler.java:209)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.opennms.core.concurrent.LogPreservingThreadFactory$3.run(LogPreservingThreadFactory.java:124)
at java.lang.Thread.run(Thread.java:745)
Exception in thread "Scheduler-Thread-3-of-5" java.lang.NullPointerException
at org.opennms.netmgt.enlinkd.NodeDiscoveryBridgeTopology.run(NodeDiscoveryBridgeTopology.java:498)
at org.opennms.netmgt.enlinkd.scheduler.Scheduler$1.run(Scheduler.java:209)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.opennms.core.concurrent.LogPreservingThreadFactory$3.run(LogPreservingThreadFactory.java:124)
at java.lang.Thread.run(Thread.java:745)
Also I got many not Ready warning in enlinkd.log
2016-12-20 12:53:42,829 DEBUG [java.util.concurrent.ThreadPoolExecutor@6e9275db[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]] o.o.n.e.s.Scheduler: run: not ready ready runnable ReadyRunnable BridgeLinkNodeDiscovery ip=37.128.138.239 port=161 community=ma14na165ge package=default
2016-12-20 12:53:42,829 DEBUG [java.util.concurrent.ThreadPoolExecutor@6e9275db[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]] o.o.n.e.s.Scheduler: run: not ready ready runnable ReadyRunnable IpNetToMediaLinkNodeDiscovery ip=172.25.64.12 port=161 community=ma14na165ge package=default
2016-12-20 12:53:42,829 DEBUG [java.util.concurrent.ThreadPoolExecutor@6e9275db[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]] o.o.n.e.s.Scheduler: run: not ready ready runnable ReadyRunnable IpNetToMediaLinkNodeDiscovery ip=37.128.138.239 port=161 community=ma14na165ge package=default
2016-12-20 12:53:42,829 DEBUG [java.util.concurrent.ThreadPoolExecutor@6e9275db[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]] o.o.n.e.s.Scheduler: run: not ready ready runnable ReadyRunnable DiscoveryBridgeTopology node=6
2016-12-20 12:53:42,829 DEBUG [java.util.concurrent.ThreadPoolExecutor@6e9275db[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]] o.o.n.e.s.Scheduler: run: not ready ready runnable ReadyRunnable IpNetToMediaLinkNodeDiscovery ip=172.25.200.171 port=161 community=verVZserVZ12 package=default