Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ONMS starts with broken threshold configuration file

Description

If your threshold config is broken (eg. broken XML code), ONMS starts without problems.
But you will get no alarms. Collectd log then says:

2017-01-31 13:39:57,271 ERROR [Collectd-Thread-1-of-50] o.o.n.t.ThresholdingSet: initThresholdsDao: Could not initialize DefaultThresholdsD
ao
org.exolab.castor.xml.MarshalException: The element type "group" must be terminated by the matching end-tag "</group>".

An ONMS start should validate the threshold xml code while starting. Like other problems this error messages should appear in output.log.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Marcel Fuhrmann May 7, 2018 at 5:48 PM

Very good! Thanks a lot!

Benjamin Reed May 7, 2018 at 5:47 PM

It should.  I now actually initialize the threshd configuration factories at the startup of Collectd so it should fail immediately instead of getting stuck in a half-working state when the first threshold set is initialized later during runtime.

Marcel Fuhrmann May 7, 2018 at 3:55 PM

I found an other issue in a threshd config. A missing single quote at the end. Everything seems to work. Of course this threshold didn't work.

Do your changes cover that case, too?

Benjamin Reed May 4, 2018 at 3:22 PM

Marcel Fuhrmann May 1, 2018 at 9:12 PM

@ranger Is the config-tester also able to test the threshold files after fixing this issue?

/cc @jblake

Fixed

Details

Assignee

Reporter

Labels

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created January 31, 2017 at 8:00 AM
Updated May 21, 2018 at 2:46 PM
Resolved May 9, 2018 at 2:08 PM