Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

config-tester doesn't check opennms.properties

Description

typos in /opt/opennms/etc/opennms.properties or
/opt/opennms/etc/opennms.properties.d/snmp-behavior.properties are not discovered. These files seems not to be tested by the config-tester

../bin/config-tester -va | grep properties
Testing exclude-ueis.properties ... OK (0.001s)
Testing javamail-configuration.properties ... OK (0.001s)
Testing magic-users.properties ... OK (0.068s)
Testing model-importer.properties ... OK (0.0s)
Testing poller-config.properties ... OK (0.004s)
Testing response-adhoc-graph.properties ... OK (0.008s)
Testing response-graph.properties ... OK (0.005s)
Testing rrd-configuration.properties ... OK (0.001s)
Testing snmp-adhoc-graph.properties ... OK (0.001s)
Testing snmp-graph.properties ... OK (0.089s)

Environment

linux

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Patrick Schweizer May 21, 2018 at 8:32 PM

@Jesse, thank you for clarification. I changed the PR: https://github.com/OpenNMS/opennms/pull/1980

Jesse White May 21, 2018 at 1:50 AM

, yes that's correct.

 

 

Patrick Schweizer May 21, 2018 at 1:07 AM
Edited

Based on my discussion with Jesse we will change the requirement:

  • only validate the syntax of files (e.g. is a properties file readable) => will remove specific file checks like OpenNmsPropertiesCheck

  • since opennms.properties.d contains only .properties files (no xml) I can also remove XMLSyntaxChecker

 @j-white could you confirm that this is what we want? Thanks!

Patrick Schweizer May 16, 2018 at 11:03 AM

Patrick Schweizer May 16, 2018 at 10:58 AM

I added 2 new functionalities:

  1. Testing of known Properties files that don't belong to a Spring Bean, e.g. opennms.properties

  2. Syntactical testing of unknown files in a directory, see PropertiesSyntaxChecker and XMLSyntaxChecker

Still open:

OpenNmsPropertiesCheck => add checks for all entries (so far only one entry is validated).

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created February 17, 2017 at 5:56 AM
Updated May 23, 2018 at 1:10 PM
Resolved May 23, 2018 at 1:10 PM