Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Minion RPM spec doesn't build enough projects

Description

The Minion RPM spec uses --projects ... --also-make to do its builds and it includes the following list of projects inside create-minion-assembly.sh:

This is intended to build basically everything underneath features/minion but because we're using --also-make, it only builds down to the projects that are specified. Therefore, the child projects of:

are not rebuilt.

This might be a cause of the occasional problems that we see where the smoke tests appear to use out-of-date artifacts.

Acceptance / Success Criteria

None

Lucidchart Diagrams

Activity

Show:

Benjamin Reed March 5, 2018 at 9:06 PM

Jesse White February 20, 2018 at 1:41 AM

PR merged to release-21.0.5, keeping open pending changes to foundation-2017.

Benjamin Reed February 16, 2018 at 3:15 PM

https://github.com/OpenNMS/opennms/pull/1866

 

Also, FYI, this should probably target foundation-2017 as well, but the fix is different since the minion compile isn't broken out into a script, it's just in the RPM spec.

 

Once we merge this, I'll commit the 2017 fix manually:

Fixed

Details

Assignee

Reporter

Components

Sprint

Fix versions

Affects versions

Priority

PagerDuty

Created February 14, 2018 at 3:52 PM
Updated March 14, 2018 at 2:03 PM
Resolved March 13, 2018 at 4:46 PM