Smoke test improvements and small tweaks to help developers

Description

None

Acceptance / Success Criteria

  1. Disable code coverage collection by default in smoke tests

  2. Speedup thread dump collection and store in its own file

  3. Allow thread dumps on shutdown to be disabled.

  4. Add "restart-fast" option to opennms script.

Activity

Show:

DJ Gregor April 23, 2023 at 8:42 PM

This has been merged into foundation-2023

Veena Kannan March 22, 2023 at 6:58 PM

Hi , do you think you’ll be able to resolve this?

DJ Gregor February 8, 2023 at 5:26 PM

FYI: I added 31.0.4 and Meridian-2023.1.0 back to the fixVersion list. The main commit for this is already in those earlier releases, but there is a noisy test issue that crept in that I need to fix, which is why I reopened this.

DJ Gregor February 4, 2023 at 9:02 PM

Part of the experiment got out of the lab:

– from https://app.circleci.com/pipelines/github/OpenNMS/opennms/27460/workflows/3bc73d14-5f2b-4782-a977-1f3791e24fd8/jobs/222958

It’s looking for the output.log file, which doesn’t exist in the container (except in one of my branches) – it needs to look at the log output from the container.

DJ Gregor February 3, 2023 at 5:08 AM

I added this to the container improvements epic and I submitted a PR against foundation-2023 because the first item (disabling code coverage collection by default) makes smoke tests take about half as long when running locally, and I think we’ll be doing a lot more of that going forward, at least for awhile. The second item also shaves off about five seconds every run. Not a lot of time, but it adds up.

(PS: don’t worry, code coverage collection is still enabled by default in CI, and developers can enable it locally if they want with -Pprofile).

I also included two other small enhancements that are low risk to the opennms startup script that are useful in some developer workflows (a new sub-command to speed up restarts and a configuration option to make logs less noisy by disabling thread dumps on shutdown). By default, everything acts the same as before, though.

Fixed

Details

Assignee

Reporter

Components

Priority

PagerDuty

Created February 3, 2023 at 5:03 AM
Updated May 8, 2023 at 2:14 PM
Resolved April 23, 2023 at 8:42 PM